Menu
▾
▴
#2775 (ok 3.0.1) Page displayed wrongly with long SQL query
This happens when I use Internet Explorer 7, but not with Fire Fox 3.
After doing an import, only the text shown below is visible below the row of tabs. To view the rest of the page (the "file to import" section, etc) you have to use the scroll bars which appear to the right of the import results. Clicking on the import tab redisplays the page correctly (without the import results at the top and without scrollbars).
Import has been successfully finished, 7 queries executed.
-- phpMyAdmin SQL Dump
-- version 3.0.0
-- http://www.phpmyadmin.net
--
-- Host: localhost
-- Generation Time: Oct 08, 2008 at 04:16 PM
-- Server version: 5.0.67
-- PHP Version: 5.2.6
Discussion
At the end of this coment is part of the page source from the page that appears after doing the import. The function PMA_showMessage() in libraries/common.lib.php (around line 1180) executed this "if" which truncated the $query_base value and then appended "[...]".
if ($query_too_big) {
echo substr($query_base, 0, $cfg['MaxCharactersInDisplayedSQL']) . '[...]';
} else {
echo $query_base;
}
The problem is that when it truncated $query_base, it split a "<br />" in half so that all we got was "<b". Firefox seems to ignore the malformed tag, but IE7 does not.
I found that by outputing a fully formed "<br />" after the "[...]" then IE7 displayed the page the same way Firefox did. Below is the modified echo line.
echo substr($query_base, 0, $cfg['MaxCharactersInDisplayedSQL']) . '[...]<br />';
------ Sample page source with the problem for IE7 (see final line for malformed <br />) ---------
<div class="success">Import has been successfully finished, 7 queries executed.</div><code class="sql">-- phpMyAdmin SQL Dump<br />
-- version 3.0.0<br />
-- http://www.phpmyadmin.net<br />
--<br />
-- Host: localhost<br />
-- Generation Time: Oct 08, 2008 at 04:16 PM<br />
-- Server version: 5.0.67<br />
-- PHP Version: 5.2.6<br />
<br />
SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";# MySQL returned an empty result set (i.e. zero rows).<br />
<br />
<br />
<br />
/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;# MySQL returned an empty result set (i.e. zero rows).<br />
<br />
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;# MySQL returned an empty result set (i.e. zero rows).<br />
<br />
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;# MySQL returned an empty result set (i.e. zero rows).<br />
<br />
/*!40101 SET NAMES utf8 */;# MySQL returned an empty result set (i.e. zero rows).<br />
<br />
<br />
--<br />
-- Database: `test2`<br />
--<br />
<br />
-- --------------------------------------------------------<br />
<br />
--<b[...]</code><div class="tools"></div></div><br />
Fixed in subversion, thanks for reporting.