Menu

#406 (ok 2.11.8) Table List Pagination

closed-accepted
None
1
2008-07-28
2008-06-07
Jason Day
No

Patch for table list pagination in the left navigation window:
http://sourceforge.net/tracker/index.php?func=detail&aid=1772222&group_id=23067&atid=377411

Discussion

  • Jason Day

    Jason Day - 2008-06-07

    navigation.php pagination patch

     
  • Marc Delisle

    Marc Delisle - 2008-06-11
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2008-06-11

    Logged In: YES
    user_id=210714
    Originator: NO

    I sent you a private email about a bug encountered with this patch.

     
  • Jason Day

    Jason Day - 2008-06-12

    navigation.php pagination patch v2

     
  • Jason Day

    Jason Day - 2008-06-12

    Logged In: YES
    user_id=1399574
    Originator: YES

    New version that correctly handles the database drop-down in the left navigation window (navigation.php_2.patch).
    File Added: navigation.php_2.patch

     
  • Marc Delisle

    Marc Delisle - 2008-06-12
    • priority: 5 --> 1
    • summary: Table List Pagination --> (ok 2.11.8) Table List Pagination
    • status: open --> open-accepted
     
  • Marc Delisle

    Marc Delisle - 2008-06-12

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged in subversion, thanks.

     
  • Jürgen Wind

    Jürgen Wind - 2008-06-12

    Logged In: YES
    user_id=1383652
    Originator: NO

    nice work!
    now the msg, "( 0 .. 12 / 26 )" is not needed any longer, it is even mileading now.

    Also I'd suggest to change "Page number:" to
    "DB page:" resp. "Table page:"

    just my 2 cent

     
  • Jürgen Wind

    Jürgen Wind - 2008-06-12

    Logged In: YES
    user_id=1383652
    Originator: NO

    correction/addition:
    now the msg, "( 0 .. 12 / 26 )" is not needed any longer

    it is even misleading now
    IN TRUNK.
    =========

    in QA/2.11.8-dev it shows the correct table numbers.

     
  • Marc Delisle

    Marc Delisle - 2008-06-12

    Logged In: YES
    user_id=210714
    Originator: NO

    I was not sure about displaying the hint (0 .. 12 / 26). OK I removed it.

    About the messages, I agree to improve but unfortunately, for 2.11.x we are in bugfix mode so by tradition we don't add new messages.
    I am not happy about having the same message "Page number:" either, so I suggest for 2.11.8 to leave "Page number" for databases and to display "Page number: (Table) for the tables. This way I can reuse previous messages.

    The first one for databases is relatively near the db selector so maybe we can let it like this.
    For 3.0 we have more liberty with the messages. I'm open to suggestions :)

     
  • Jürgen Wind

    Jürgen Wind - 2008-06-12

    Logged In: YES
    user_id=1383652
    Originator: NO

    ah, ok @2.11 ..
    but for 3.0 "DB/Table - page" would be more user-friendly, wouldn't it?

     
  • Marc Delisle

    Marc Delisle - 2008-06-12

    Logged In: YES
    user_id=210714
    Originator: NO

    I'm looking for something clearer. You see, what is a "Table page"? We mean a page for a list of tables but I'm not sure that "Table page" means this.

     
  • Jürgen Wind

    Jürgen Wind - 2008-06-13

    Logged In: YES
    user_id=1383652
    Originator: NO

    Agreed,
    must sound funny in the ears of native english speakers ;)

    Maybe a <hr> ( or somthing like {border-top:.1em solid blue}) above the table pager would be enough to make the context of "Page number" clearer.

     
  • Marc Delisle

    Marc Delisle - 2008-06-13

    Logged In: YES
    user_id=210714
    Originator: NO

    ... I'm not a native English speaker but it sounds funny indeed.
    Good idea about the separating line.

    Also, I'm thinking about replacing "Page number" by just "Page" because it's evident that what follows is a number.

     
  • Marc Delisle

    Marc Delisle - 2008-07-28
    • status: open-accepted --> closed-accepted