Menu

#2702 (ok 3.0) problem with comma and quote in enum

fixed
1
2013-06-11
2008-06-02
No

Hello,

there's 2 little issues with comma and quote put together :

1) When having ",'" (comma and quote) in a enum's value, there's a problem to display correctly escaped ' character in tbl_structure.php and libraries/tbl_properties.php

Example : Create a table with an enum field with length/values "'good ol\'test','foo,\'bar'".
We should have an enum field wich can be "good ol'test" or "foo,'bar". But in tbl_structure.php and libraries/tbl_properties.php, it appears as : enum('good ol\'test', 'foo, ''bar')

Note that "good ol'test" is well displayed, but the other have "double simple-quote" escape type.
This issue seems not really annoying, displaying just a not really rigorous "not same escape style in a string". tbl_change.php's "enum's list" aren't affected.

Error seems to be on :
-librairies/tbl_properties.inc.php - line 274
-tbl_struture.php - line 260

2) When having "','" (quote, comma and quote), there's a problem with the "enum's list" of tbl_change.php where the value is split in 2 part (before and after the "','").

Example : Create a table with an enum field with length/values : "'good ol\'test','foo\',\'bar'".
We have the same problem display problem then before, we can see : enum('good ol\'test', 'foo\', ''bar'). But the real issue is in the "enum's list" of tbl_change.php : "good ol'test", "foo'","'bar".

Error seems to be on :
libraries/common.lib.php - function PMA_getEnumSetOptions($type_def) - line 1445

Bug seen on :
phpMyAdmin - 2.11.6

Discussion

  • Marc Delisle

    Marc Delisle - 2008-07-01
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2008-07-05

    Logged In: YES
    user_id=210714
    Originator: NO

    Ok, please have a look at latest trunk (for 3.0-dev), all should be OK. Details to get a snapshot of trunk are at phpmyadmin.net on the Downloads page.

     
  • Marc Delisle

    Marc Delisle - 2008-07-05
    • priority: 5 --> 1
    • summary: problem with comma and quote in enum --> (ok 3.0) problem with comma and quote in enum
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2008-09-27
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed