Menu

#401 (ok 2.11.6) colon in PW prevents login (http)

closed-fixed
None
1
2008-04-29
2008-03-31
No

when users have a colon in their password they can't login using auth_type "http" on some CGI installations due to the explode function.

fix for, e.g., version QA_2_11, libraries/auth/
* @version $Id: http.auth.lib.php 10893 2007-11-01 20:59:48Z lem9 $

@ line 140:
- if (!empty($usr_pass) && strpos($usr_pass, ':') !== false) {
- list($PHP_AUTH_USER, $PHP_AUTH_PW) = explode(':',
$usr_pass);
- }

+ if (!empty($usr_pass)) {
+ $colon = strpos($usr_pass, ':');
+ if($colon) {
+ $PHP_AUTH_USER = substr($usr_pass, 0, $colon);
+ $PHP_AUTH_PW = substr($usr_pass, $colon + 1);
+ }
+ unset($colon);
+ }

Discussion

  • Marc Delisle

    Marc Delisle - 2008-04-03
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2008-04-03
    • priority: 5 --> 1
    • summary: colon in PW prevents login (http) --> (ok 2.11.6) colon in PW prevents login (http)
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2008-04-03

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged in subversion, thanks.

     
  • Marc Delisle

    Marc Delisle - 2008-04-29
    • status: open-fixed --> closed-fixed