Menu

#671 MUI_RESERVEFILE_INSTALLOPTIONS fails install build

2.0 Series
closed-fixed
Modern UI (97)
5
2007-12-22
2007-08-29
Seg
No

NSIS 2.30
MUI 2
MUI 2 Documentation

The macro MUI_RESERVEFILE_INSTALLOPTIONS is deprecated as InstallOptions isn't used anymore with MUI 2. However, the documentation for MUI 2 still lists as one of the requirements for properly using SOLID compression. The sample code should read:

Script Header -> 5. Reserve files
ReserveFile "ioFile.ini" ;Your own InstallOptions INI files
!insertmacro MUI_RESERVEFILE_LANGDLL ;Language selection dialog

Separately, would it be possible to include the MUI_RESERVEFILE_INSTALLOPTIONS back into MUI2? Only to generate a warning error and prevent failing a build? Yes, this function would serve no functionality, but it's scary to have a installer fail for a non-issue. It also makes rolling up to the new MUI version with older scripts work out of the box.

Discussion

  • Seg

    Seg - 2007-08-29

    Logged In: YES
    user_id=1878881
    Originator: YES

    Forget the documentation part. I thought I was looking at the Beta 2 documentation, when really I was looking at the 1.80 version. Sorry!

    However, I still stand for the MUI_RESERVEFILE_INSTALLOPTIONS function itself. I am aware that all MUI_INSTALLOPTIONS_* macros should be changed to INSTALLOPTIONS_* macros, but MUI_RESERVEFILE_INSTALLOPTIONS does not have a non-MUI counterpart.

     
  • Amir Szekely

    Amir Szekely - 2007-12-22

    Logged In: YES
    user_id=584402
    Originator: NO

    Added Deprecated.nsh for some warning/error fun on the move from MUI to MUI2.

     
  • Amir Szekely

    Amir Szekely - 2007-12-22
    • assigned_to: joostverburg --> kichik
    • status: open --> closed-fixed
     

Log in to post a comment.