Menu

#2514 (ok 2.11.1) Logout causes CSS loss

2.11.0
fixed
Interface (555)
1
2013-06-11
2007-08-23
No

Hi,

I'm using the latest 2.11.0 release. When logging out, I'm sent to the login page as usual, but the login page lacks CSS formatting. A reload solves it.

Steps to reproduce:
1) Login to phpMyAdmin.
2) Press "logout".
3) Get the login page but without CSS (very wide Login box, for example)
4) Press browser reload.
5) Get the correct login page.

A guess is that this has something to do with the "token" passed to phpmyadmin.css.php.

Let me know if you need more information to debug this.

thanks!
Thijs

phpMyAdmin 2.11.0 release
PHP 5.2.3
Apache 2.2.4
Firefox 2.0.0.6

Discussion

  • Lukáš Chmela

    Lukáš Chmela - 2007-08-23

    Logged In: YES
    user_id=1790839
    Originator: NO

    I'm getting the same result.

    Versions of my phpMyAdmin, PHP and Apache are the same.
    I'm usually using IE7 on Windows XP.

     
  • Lukáš Chmela

    Lukáš Chmela - 2007-08-24

    Logged In: YES
    user_id=1790839
    Originator: NO

    OK, I cannot attach any files there, so I added some screenshot of the login page ( cookie method ) after unlogin in phpMyAdmin-2.11.0 to my server:

    http://82.114.202.3/unlogin_phpMyAdmin-2.11.0.png

    The server goes from about 8:00 GMT to about 21:00 GMT.

    I found some differences between the correct login page and the incorrectly showed login page after unlogin in PMA's HTML code - stylesheet ( there are differences in the token ).
    BTW HTML seems to be the same.

    The tag of the incorrectly showed page:
    <link rel="stylesheet" type="text/css" href="phpmyadmin.css.php?token=f3a113e0039b6944f6a87e3f8b0f309a&amp;js_frame=right&amp;nocache=1187977413" />

    The tag of the correctly showed page:
    <link rel="stylesheet" type="text/css" href="phpmyadmin.css.php?token=f6292ebf45870911f2d2b1231eab6842&amp;js_frame=right&amp;nocache=1187977838" />

     
  • Marc Delisle

    Marc Delisle - 2007-08-25

    Logged In: YES
    user_id=210714
    Originator: NO

    I have seen this behavior but for me it's intermittent. Cannot reproduce it with the steps given.

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-25

    Logged In: YES
    user_id=1383652
    Originator: NO

    I have this issue all the time in pma >= 2.11 !

    From the source after logout:
    ...
    <link rel="stylesheet" type="text/css" href="phpmyadmin.css.php
    ?token=826fdc6eda4e0179fbf4af2c1d9c050b
    &amp;js_frame=right
    &amp;nocache=1188045814" />
    ...

    but the inspection of the css gives:
    ...
    /* navi Grid-2.11 070815 for pma 2.8 ... 2.11+ */
    * {
    ...

    so it seems that phpmyadmin.css.php grabs the wrong file for inclusion.

    @Thijs:
    the tokens in the "link rel...", $_GET and $_SESSION are identical and look ok

     
  • Marc Delisle

    Marc Delisle - 2007-08-25

    Logged In: YES
    user_id=210714
    Originator: NO

    windkiel,
    do you have the issue when using the original theme?

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-25

    Logged In: YES
    user_id=1383652
    Originator: NO

    yes

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-25

    Logged In: YES
    user_id=1383652
    Originator: NO

    GET-Array
    (
    [token] => ef221d13f5c21edc688db6b45297b64b
    [old_usr] => p0p
    )

    seems that we need an additional "&js_frame=right" when coming from logout.

    btw.
    "js_frame" sounds like a historic naming, I'd suggest using just "frame"

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-25

    Logged In: YES
    user_id=1383652
    Originator: NO

    quick&dirty patch:
    phpmyadmin.css.php, line 793:
    -$_SESSION['PMA_Theme_Manager']->printCss($_REQUEST['js_frame']);
    +$_SESSION['PMA_Theme_Manager']->printCss( empty($_REQUEST['js_frame']) ? 'right' : $_REQUEST['js_frame'] );

     
  • Marc Delisle

    Marc Delisle - 2007-08-26
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2007-08-26

    Logged In: YES
    user_id=210714
    Originator: NO

    I don't understand. In my tests, from the source after logout, the js_frame=right is always there.
    But I noticed that if I add
    echo ' ';
    in phpmyadmin.css.php, just before the first "define", I have no CSS in my login form and I get an error in my FF error console.

    I would like to reproduce this problem.
    I also tried with a value in $cfg['Servers'][$i]['LogoutURL'] but could not reproduce.

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-26

    Logged In: YES
    user_id=1383652
    Originator: NO

    To be sure how to reproduce I installed phpMyAdmin-2.11.0-english.7z on a w2k (wamp5) box, created a simple config file and copied the whole pma211 folder (using ssh) to a linux box running xampp 163a. Interestingly I *only* (but always after logout) have this issue on the *win2000* box. (my previous tests used pma3(trunk) on a different w2k laptop).

    >I would like to reproduce this problem.
    That's fully understandable. Although the little patch fixed the problem I'll do some more debugging as well ;)

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-26

    Logged In: YES
    user_id=1383652
    Originator: NO

    2nd patch (line 11):

    define('PMA_MINIMUM_COMMON', true);
    +define('_Frame', empty($_REQUEST['js_frame']) ? 'right' : $_REQUEST['js_frame'] );
    require_once './libraries/common.inc.php';
    ^ here $_REQUEST['js_frame'] gets resetted (at least under windows) !
    so the original GET has to be saved before common.inc is called.
    then the last line must make use of the saved value:

    -$_SESSION['PMA_Theme_Manager']->printCss($_REQUEST['js_frame']);
    +$_SESSION['PMA_Theme_Manager']->printCss( _Frame );

    p.s.:
    I vagely remember that this was an issue already some months ago - and now again - when many users (all on win IIRC) complained in the help forum about css in the *right* frame not being loaded. To find the *real* culprit I leave to others.

     
  • Marc Delisle

    Marc Delisle - 2007-08-26

    Logged In: YES
    user_id=210714
    Originator: NO

    Ok, which browser on your w2k laptop?

    I have access to a w2k server; there I tested FF 1.0.7 and IE 5 (PHP running on a Linux server) and I see no problem.

    I'll try to find a machine with w2k on it.

     
  • Jürgen Wind

    Jürgen Wind - 2007-08-26

    Logged In: YES
    user_id=1383652
    Originator: NO

    issue with any browser:
    IE6, IE7, SeaMonkey112, FF 2.0.05, Opera9.23
    (all clients w2k or xp)

    on servers (apache 2.2):
    w2k php 5.2.3 (always)
    xp (prof.) php 5.2.2 (always)
    linux php 5.2.0 (only sometimes)

     
  • Marc Delisle

    Marc Delisle - 2007-08-28

    Logged In: YES
    user_id=210714
    Originator: NO

    Thijs,
    I guess you are not using a browser on a W2K machine :) on which browser do you see this problem?

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2007-08-28

    Logged In: YES
    user_id=285765
    Originator: YES

    Firefox 2.0.0.6 on Debian.

     
  • Jürgen Wind

    Jürgen Wind - 2007-09-01

    Logged In: YES
    user_id=1383652
    Originator: NO

    seems to be a gereral issue:
    http://sourceforge.net/forum/forum.php?thread_id=1802495&forum_id=72909
    and on IRC a guy named ryan reported the same issue, he used a fresh folder
    (Window XP, MySQL 5.0.41, php 5.2.3, Apache) - the patch fixed his problem :)

     
  • Marc Delisle

    Marc Delisle - 2007-09-02
    • priority: 5 --> 1
    • summary: Logout causes login page to be displayed without css --> (ok 2.11.1) Logout causes CSS loss
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2007-09-02

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged, thanks.

     
  • Marc Delisle

    Marc Delisle - 2007-09-20
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed
     
MongoDB Logo MongoDB