(ok 2.11.3) Remove horizontal lines in navigation panel

Logged In: YES
user_id=210714
Originator: NO

In original and darkblue_orange themes, I removed all horizontal lines except the one that separates each db when $cfg['LeftFrameLight'] is false.

Patch set:
http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin?view=rev&revision=10868

Please try it and comment here.

Logged In: YES
user_id=30264
Originator: YES

> The database list in the left frame shouldn't be underlined (IMO).

The links are still underlined in 2.11.2.

Logged In: YES
user_id=210714
Originator: NO

Did you write about links previously in this bug report? If no, why reopen this bug report?

And which links are you talking about?

Logged In: YES
user_id=30264
Originator: YES

Yes, I did: "The database list in the left frame shouldn't be underlined (IMO)."
I mean the list items in the databases list.

Logged In: YES
user_id=210714
Originator: NO

Why do you think it is a problem to have underlined links for the database list in the original and darkblue_orange themes?

Do you mean the list of databases shown when none has been selected?

Logged In: YES
user_id=30264
Originator: YES

> Do you mean the list of databases shown when none has been selected?

Yes, I do.

Other links aren't underlined either and it seems silly to underline such a large amount of text. It also reduces readability.

Logged In: YES
user_id=1383652
Originator: NO

you may like theme "Grid" then ;)

Logged In: YES
user_id=30264
Originator: YES

That theme isn't part of the default package, right?

Logged In: YES
user_id=1383652
Originator: NO

correct:
https://sourceforge.net/project/showfiles.php?group_id=23067&package_id=204059&release_id=547654

Logged In: YES
user_id=210714
Originator: NO

Ok I'll change it for 2.11.3. In the past I was looking at the list of tables when a database has been selected.

And let's have the best original and darkblue_orange themes possible ;)

Logged In: YES
user_id=1383652
Originator: NO

>And let's have the best original and darkblue_orange themes possible ;)
I second that, in the last "fix" you removed too many solid bottom lines IMHO see "table__grouping":
http://pma.cihar.com/trunk-config/?db=test&table=jwk__1777249trk

@version $Id: original/theme_left.css.php 10868,
line 195 patch:

div#left_tableList ul ul {
margin-<?php echo $left; ?>: 0;
padding-<?php echo $left; ?>: 0.1em;
+ border-bottom: 0.1em solid <?php echo $GLOBALS['cfg']['NaviColor']; ?>;
border-<?php echo $left; ?>: 0.1em solid <?php echo $GLOBALS['cfg']['NaviColor']; ?>;
padding-bottom: 0.1em;
}

Logged In: YES
user_id=210714
Originator: NO

Well, it was my understanding that these bottom lines were asked to be removed in this bug report and indeed, I think there were too many of them.

What's the problem with
http://pma.cihar.com/trunk-config/?db=test&table=jwk__1777249trk

Logged In: YES
user_id=1383652
Originator: NO

>What's the problem with
no *problem* but I think *this* separator line was not meant originally.
It just helps to recognize the (end of the) group at first glance.

I just like the old style better (see Grid or pma 2.10):

--8<--
someTables
[+]jwk_
| t111111111
| t222222222
|___________
otherTables
--8<--

YMMV

Logged In: YES
user_id=210714
Originator: NO

In 2.11.3 links are no longer underlined in left panel (for the 2 packaged themes).

windkiel: I see no difference between current QA_2_11 and 2.10.3 concerning the display of table groupings in the left panel.

Logged In: YES
user_id=1383652
Originator: NO

well,
I complained about "trunk". It just looks ugly after you removed some horizontal lines.
Click on [+] to unfold the table tree of db test:
--8<--
someTables
[-]jwk_
| t111111111
| t222222222
otherTables
--8<--

Logged In: YES
user_id=210714
Originator: NO

Oops, this was a test I forgot to remove in trunk. Fixed now.