Menu
▾
▴
#154 Add new command, LOGFILE. Also fix code error.
Hi all,
This patch adds a new command called "LOGFILE".
It allows the user to select a different file name and/or path for the log file, assuming NSIS_CONFIG_LOG is enabled.
It also allows the user to change the log file name and location during the run of the Installer.
NOTE:
If this command is not called, NSIS logging acts exactly as it did before this command was/is added.
REASON FOR ADD:
For Installers that install many different yet very large "packages", its very useful to be able to split the log file into logical package chunks.
ALSO:
This patch fixes a copy/paste error in the existing NSIS code.
(exec.c -> CreateDirectory -> NSIS_CONFIG_LOG on -> used buf, should be buf1.)
Logged In: YES
user_id=1861584
Originator: YES
File Added: nsis_logfile.patch
Logged In: YES
user_id=584402
Originator: NO
Thanks, that's a useful addition. A few notes before inclusion:
* Use NSIS_MAX_STRLEN instead of 1024. You can also use buf1 instead of name[1024].
* Use findlastslash and friends instead of reimplementing them.
* Why not use $INSTDIR instead of the current directory? That'd be more consistent with the current path and won't depend on the user.
* All other commands don't create the directory for the user, so this makes LogFile stand out in the crowd. The code is also copied from EW_CREATEDIR so, if already creating the directory, why not just adding another EW_CREATEDIR opcode before the EW_LOG opcode?
* Use two spaces for indention instead of tabs.
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).