Menu
▾
▴
#2459 (ok 2.11) LeftLogoLink fails if set to some external sites
-
I have this in my config:
$cfg['LeftLogoLink'] = 'http://www.phpmyadmin.net/';
When I pass the mouse over the link in the left navigation bar... it says:
http://www.phpmyadmin.net/home_page/index.php?token=c91a6dacbb780a4efb0ae7adda0942c5
When I click on it... phpmyadmin.net (and some other external sites) does not like the "?token=c91a6dacbb780a4efb0ae7adda0942c5" bit...
This means that http://www.phpmyadmin.net re-writes the address to:
http://www.phpmyadmin.netindex.php/
Which fails!
Should external LeftLogoLink addresses have the ?token bit dropped?
Logged In: YES
user_id=1175402
Originator: YES
Ooops... my LeftLogoLink is actually... (was halfway through testing a different idea)
$cfg['LeftLogoLink'] = 'http://www.phpmyadmin.net/home_page/index.php';
Basically... if it is: http://www.phpmyadmin.net or http://www.phpmyadmin.net/home_page/index.php ... it does not work...
Logged In: YES
user_id=210714
Originator: NO
I tried this patch (on trunk):
Index: libraries/navigation_header.inc.php
===================================================================
--- libraries/navigation_header.inc.php (revision 10467)
+++ libraries/navigation_header.inc.php (working copy)
@@ -31,7 +31,12 @@
echo '" target="_blank"';
break;
case 'main':
- echo '?' . $query_url . '" target="frame_content"';
+ // do not add our parameters for an external link
+ if (substr(strtolower($GLOBALS['cfg']['LeftLogoLink']), 0, 4) !== 'http') {
+ echo '?' . $query_url . '" target="frame_content"';
+ } else {
+ echo '"';
+ }
}
echo '>' . $logo . '</a>' . "\n"
.'</div>' . "\n";
It seems to work for most cases, except for this one:
$cfg['LeftLogoLink'] = 'http://www.phpmyadmin.net';
$cfg['LeftLogoLinkWindow'] = 'main';
Logged In: YES
user_id=210714
Originator: NO
Patch merged for 2.11. For an unknown reason, when linking to phpmyadmin.net you have to use 'new' for LeftLogoLinkWindow.