Menu ▾ ▴

#351 (ok 2.10.1) Addition of BINARY ColumnTypes breaks reordering

closed-accepted
Marc Delisle
Interface (183)
1
2007-05-04
2007-03-15
No

Trying to alphabetically reorder the column types in the create table interface by setting $cfg['ColumnTypes'] in config.inc.php has the BINARY and VARBINARY options added a second time at the end of the list.

Cause is the test in PMA_DBI_postConnect() in libraries/database_interface.lib.php that checks if VARBINARY is the last element in the $cfg['ColumnTypes'] array.

Instead of checking if VARBINARY is the last element and adding BINARY and VARBINARY if it is not it is cleaner to test for the existence of either with in_array().

See attached patch to fix this.

Discussion

  • Anonymous

    Anonymous - 2007-03-15

    Add BINARY and VARBINARY ColumnTypes individually using is_array() to test for their existence

     
    database_interface.lib.php.patch

  • Marc Delisle

    Marc Delisle - 2007-03-15
    • milestone: 696501 -->
    • labels: 317619 --> Interface
     

  • Marc Delisle

    Marc Delisle - 2007-03-23
    • assigned_to: nobody --> lem9
     

  • Marc Delisle

    Marc Delisle - 2007-03-23
    • priority: 5 --> 1
    • summary: Addition of BINARY ColumnTypes breaks reordering --> (ok 2.10.1) Addition of BINARY ColumnTypes breaks reordering
    • status: open --> open-accepted
     

  • Marc Delisle

    Marc Delisle - 2007-03-23

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged in subversion, thanks.

     

  • Sebastian Mendel

    Sebastian Mendel - 2007-05-04
    • status: open-accepted --> closed-accepted