Menu
▾
▴
#557 NSIS compiler issues erroneous warning on uninstall sections
Compile this script:
Name "Test"
OutFile "Test.exe"
Page instfiles
Function un.something
FunctionEnd
Section
SectionEnd
You will get a compiler warning that an uninstall section was found but WriteUninstaller was not used.
In fact, an uninstall _function_ was found, which is perfectly common.
Submitter: amayo (at) divxcorp [dotcom]
Logged In: YES
user_id=970495
Originator: NO
hmm, common?
it is quite uncommon, that you code uninstaller functions without even use an uninstaller :D
Logged In: YES
user_id=970495
Originator: NO
ok, found it:
build.cpp, lines 2211 to 2217:
if (ubuild_entries.getlen())
{
if (!uninstaller_writes_used)
{
warning("Uninstall section found but WriteUninstaller never used - no uninstaller will be created.");
return PS_OK;
}
the problem is, that only the length of the uninstall code is checked, not the type of it.
the message should be changed to something like
"Uninstall script code found but ..."
Logged In: YES
user_id=584402
Originator: NO
Thanks, fixed.