Menu

#453 section 4.9.14.8 IsWindow example incorrect

2.0 Series
closed-fixed
5
2006-02-24
2006-02-15
Anonymous
No

In section 4.9.14.8 the example given for IsWindow is
missing a dollarsign. In addition I think the logic is
wrong. I am new to the use of the Nulsoft installer
and using this example stumped me for quite a while.
The example reads:

GetDlgItem $0 $HWNDPARENT 1
IsWindow 0 +3
MessageBox MB_OK "found a window"
Goto +2
MessageBox MB_OK "no window"

I think it should read:

GetDlgItem $0 $HWNDPARENT 1
IsWindow $0 +1
MessageBox MB_OK "found a window"
Goto +2
MessageBox MB_OK "no window"

my recommendation would be to change it so that it
appears in the following manner (this example uses the
option second parameter):

GetDlgItem $0 $HWNDPARENT 1
IsWindow $0 +1 +3
MessageBox MB_OK "found a window"
Goto +2
MessageBox MB_OK "no window"

This is from version 2.09 of NSIS - I checked the
report and I didn't notice any other submissions

Discussion

  • Amir Szekely

    Amir Szekely - 2006-02-24
    • assigned_to: nobody --> kichik
    • status: open --> closed-fixed
     
  • Amir Szekely

    Amir Szekely - 2006-02-24

    Logged In: YES
    user_id=584402

    Thanks, fixed.

     

Log in to post a comment.