Merged PRs

dolt

• 10140: Full passthrough of Doltgres overrides Related PRs:
• https://github.com/dolthub/go-mysql-server/pull/3303
• https://github.com/dolthub/doltgresql/pull/2009

go-mysql-server

• 3342: Set SubqueryAlias.OuterScopeVisibility to true if inside trigger scope Fixes [#10175] Trigger scopes were being included when determining exec indexes for SubqueryAlias child nodes but were not actually passed down to child iterators during rowexec (code). As a result, we were getting index out of bounds errors since the trigger scopes were not included in the parent row. Since there's no easy way to separate the trigger scope columns out from the rest of the parent row during rowexec, it was easier to just mark SubqueryAlias.OuterScopeVisibility inside triggers to true. I think it technically does make sense here because the trigger scope is an outer scope that the SubqueryAlias does have visibility of, but I added a TODO comment in case this is incorrect.
• 3340: enable native indexes on all in-memory tables by default Also simplifies the test harness setup by removing the non-native-index cases. Fixes https://github.com/dolthub/go-mysql-server/issues/3338
• 3339: Do not erase projections for insert sources inside triggers part of [#10175] (see example 2) Erasing projections for insert sources inside triggers was causing the wrong columns to be selected when the trigger is executed. This is because the exec indexes in Project nodes inside the trigger logic account for the prepended trigger row and is needed to "trim" away the prepended row to get the right columns. The Project node that ultimately wraps the insert source, which re-projects it to match the insert destination, assumes the correct columns have already been fetched by its child node so does not account for the prepended trigger row.
• 3335: For large joins, prefer sticking to the user-supplied join order over full enumeration. This effectively reverts a change that was introduced in https://github.com/dolthub/go-mysql-server/pull/3289 (potentially by accident). For a large join (16+ tables), full enumeration of every possible join plan is too slow. In the event that we can't find a good join plan heuristically, we should stick to the original join order, and not attempt to enumerate all the possible joins. This results in worse joins in the IMDB query tests... but those tests were previously skipped because they were too slow, and we can now unskip them. Ideally we would do a better job of finding the best join without needing to fall back on an exhaustive search, but in the meantime, this serves as a workaround.
• 3334: Index lookup type conversion issues This PR addresses type conversion semantics during key lookups. Some type conversions were insufficient for Doltgres, and some were simply incorrect, notably the behavior when a value being converted was out of range, which could produce incorrect results. Other fixes addressed:
• New ExecBuilderNode interface to allow Doltgres to correctly use the custom builder overrides when building row iters
• Corrected behavior for IN and NOT IN used in index lookups for doltgres Tests for some of these changes only exist in Doltgres, will address before merging. See: https://github.com/dolthub/doltgresql/pull/2093
• 3330: Add fast path for simple IN filters If we are filtering an indexed column with a simple IN query, we can avoid building a range tree. This currently only applies to integer columns, but it's possible to expand it to floats and decimals. Also, simplifies rounding checks for float/decimal keys on integer indexes. Benchmarks: https://github.com/dolthub/dolt/pull/10133#issuecomment-3618780244
• 3303: Explicit Analyzer/Builder Overrides Related PRs:
• https://github.com/dolthub/doltgresql/pull/2009
• https://github.com/dolthub/dolt/pull/10140

Closed Issues

• 10175: Unable to find field with index ... in row of ... columns
• 7128: Truncate strings when converting to double
• 10156: syntax error in CREATE TEMPORARY TABLE statement used by Gnucash
• 3338: Foreign key behavior doesn't match modern MySQL