Menu
▾
▴
#43 new distorsion types and edge rounding limiters
this three patches enhance the distorsion module with
tunable edge rounding for limiter and inverse limiter function
3 new distorsion types square, cubic and tanh
dc offset at the input of the transfer function
new function parameter to shape the function or the edge rounding
patch inside comment in case of later editing
Last edit: friedolino 2019-09-15
Given one patch still has WIP in the commit name, should this patch set
be considered in progress, or is the patch set as a whole (after review)
merge ready?
i forgot to remove the WIP in the name. As far as I can tell it is ready.
Is there any order these patches would need to be merged, or are they independen?
they patches without prefix have to be merged in in ascending order 0001 - 0003
The rtosc patch is needed to compile them. The mrz and osc_bridge patches are needed to reflect the new controls in the new gui.
I'll review and merge this.
friedolino: the rtosc patch contains
Are you sure you did not mean
rDoc(m)?Aside from that, the patch looks OK to me.
yeah. Thats the problem of copy/paste coding style.
First of all: Many thanks for the distortion patches.
Looking at your first zyn patch (0001):
While you can infer the meanings of the parameters, a quick description of each would likely not harm
Can you give me the source for your formulae, so I can check easily whether they are all valid?
Why is the polyblamp not used for e.g. the square wave? Is it specific for limiters, or did you just not implement it there?
Can you please explain your change for distortion number 14?
in number 14 I added support for the DC offset parameter.
Because the offset is added to input and subtracted from the output, it behaves like the distorsion function is shifted, making it asymetric. I did the same also to numbers 1, 7 and 10.
Ok, I will add more comments.
Polyblamp could be applied to square wave, too. But on the effects it is more needed because often there is no more LP filtering afterwards.
About the square wave: Sorry, I confused wave and distortion.
Are you finished with adding the comments, so I can continue?
i am a little bit short of time these days. i hope, i get to it this weekend
I added a patch 0004 with more comments and source information.
sorry that it took so long.
friedolino: I can't
git amthe zyn patches to master anymore, since the master changed. Can you please do a rebase of the patches or at least give me the commit ID where you forked from master?Also, I think for code changes that are not minimal we should prefer pull-requests instead of patches.
rebased to ee366cc27904b4a8d3b7da6ed844b674a90ed309
this patch adds more explaining comments to the polyblamp function
some improvements from review comments on github
https://github.com/zynaddsubfx/zynaddsubfx/pull/41
Last edit: friedolino 2019-12-07
What is the master base commit for the osc-bridge patch?
fix for an error in the offset handling of the limiter function.
and added the new waveshapers to oscilgen parameters (used in zest)
Last edit: friedolino 2019-12-22
I'm seeing parts of this integrated. Are there still relevant pieces
of this which need discussion prior to merging?
If there are still open bits, can we consolidate this into a github
PR, (it at least feels like discussions there go a bit faster).
If everything relevant is merged, let me know and I'll shift this to closed.
all of theese patches have already been integrated on github in https://github.com/zynaddsubfx/zynaddsubfx/pull/41.
This Ticket can be closed.
friedolino: Were the mruby-zest patches also be merged? I can't recall.
yes, at eb8fa13f4f2a8da42233179f1d6861bed4ec5a5d