#129 Vsti Crash Renoise - Arch Linux 64

[Gimmeapill]

3 instances of zyn 2.5.3 in an empty document were playing when I saved...then went to hell and took Renoise with them (full log attached):

VstPlugs: Caught exception in VSTPlug::Dispatch

Error Message: A fatal error or crash occurred (unhandled exception in thread: GUI).
Error Message: A backup of the current document was saved at
Error Message: '/home/gimmeapill/.renoise/V3.1.0/CrashBackups/Renoise_TmpFile-0-3_2_12_2016__23_22_crash.xrns'...
Error Message: This either happened because of a bug in Renoise, or because of a bug in one of its loaded components (plugins). Please contact <bug@renoise.com> and report this problem, so that it can be fixed.
Error Message: Note: It's very important that we know exactly what has happened (what you were doing before this message popped up), or the problem cannot be replicated/analyzed. Please include a description of what you were doing and which components were being used...

Warning Message: Ouch. The VST plugin 'ZynAddSubFX Team: ZynAddSubFX (from ZynAddSubFX Team)' crashed in VST event/function: 'Dispatch', Thread: 'GUI'
Warning Message: IMPORTANT: This is a fatal error. Please save the current document under a !new! name to prevent losing important data. Renoise will silently ignore any following errors from this plug-in.
Warning Message: DO NOT IGNORE THIS ERROR; DO NOT CONTINUE USING THE PLUGIN. THIS CAN DESTROY YOUR SONG OR CAUSE OTHER RANDOM CRASHES AND PROBLEMS!
Warning Message: It's most likely that this is a bug in the VST plugin, so please report this problem to the authors of this plugin in order to get the problem fixed!

Graphport: Timeout while waiting for a pending 'StructureNotify' event vsti

[Mark McCurry]

After some light experimentation with the 32bit 3.1.0 renoise demo I'm unable to create a crash. Do you have a file from which a crash is somewhat easy to generate?

[Gimmeapill]

Attached is my test file. It crashes on save actually (I just reproduced it). Happens on the 64 bit version of Renoise.

[Mark McCurry]

I cannot replicate the crash on 64 or 32 bit 3.1.0 demos, but I do see some invalid memory accesses in valgrind. I'll update again when there's another build to test.

[Mark McCurry]

All invalid behavior on my 64 bit machine seems to be rectified. Can you rebuild and see if this resolves your issue?

[Gimmeapill]

Still crashing with zynaddsubfx-git-2.5.3.r4.ge52dd05.
I reproduced the crash with the same test file: changing presets in the 3 instances then saving while playing. latest log file attached

[Mark McCurry]

That commit doesn't contain the fixes for the found undefined behavior. You'll need 9d05fae274fa74cd84a73f679f46ed3e1969f939 or a more recent commit to get the fixes. Preferably the git head would be used which is currently 2ba6c53a3dd47f66d073a9c43633564315b85bdf .

[Gimmeapill]

Confirmation: crash is fixed as of git-2.5.3.r26.gbda89cf
Thanks!