|
From: Craeg K S. <cs...@ar...> - 2003-04-11 05:30:28
|
Brent Hendricks wrote: > Craeg Strong wrote: > >>> Did you have any thoughts about my suggestion to move >>> getXSLParameters() into XSLTMethod? >> > The patch implementing this a little larger, so I put it at > http://thehendricks.org/zxmlmethods/zxmlmethods-request-patch-v2 Yes, it looks as I expected it to. Philipp is about to refactor the processor stuff into a separate package, so we should coordinate this change. (Philipp are you already in process? If so, you should probably just add this to your list since you will be in that code. If not, I can do it Saturday) > After looking at it for a bit, it definitely looks like it will make > testing Zope Products pretty straightforward. yep. I can't imagine testing without it. You have a full REQUEST object, folders, permissions, and a running ZPublisher instance, so you can do virtually anything you could do in the ZMI. In fact, to a certain extent it even affects the design of ZopeXMLMethods, because I like to design for testability. > I have a question about tests 7 and 8 now that I'm moving > getXSLParameters() into XSLTMethod: wouldn't it be better to test the > getXSLParamaters() method by itself to verify that it was grabbing > parameters correctly without actually doing a transformation? Then we > could have a separate test for passing parameters to the XSLTProcessor. > It just just seems more in the unit test spirit of "test one thing". Yes. In fact, you should check out the code in TestXSLTProcessor.py where I do a loop through all available processors and test the output of each one. Your test should probably do the same thing to ensure that parameters work for each and every one. I don't have *every* processor installed on *every* operating system, but between windows 2000 and Linux I have at least one installation of each one. So I am happy to help out with testing. My next project is going to be recompiling Zope with Python 2.2 and trying that out. Apparently, the Python XML libraries behave significantly better under 2.2 there were some changes under the hood that dramatically decrease memory usage and such. For example: docbook is virtually unusable under python 2.1.x and apparently runs ok under python 2.2 What OS/Zope(s) are you using, out of curiousity? --Craeg |
