|
From: Brent H. <br...@ec...> - 2003-04-11 00:59:20
|
Craeg Strong wrote: >>Did you have any thoughts about my suggestion to move >>getXSLParameters() into XSLTMethod? I'd be happy to put together a >>patch for that as well. > > > Yes, I think its the right thing to do. There is nothing > processor-specific about grabbing the params, so > why should the method be in a processor specific class? Agreed. The patch implementing this a little larger, so I put it at http://thehendricks.org/zxmlmethods/zxmlmethods-request-patch-v2 > I think you will be amazed how easy it is to add > a test-- ZopeTestCase rocks! After looking at it for a bit, it definitely looks like it will make testing Zope Products pretty straightforward. I have a question about tests 7 and 8 now that I'm moving getXSLParameters() into XSLTMethod: wouldn't it be better to test the getXSLParamaters() method by itself to verify that it was grabbing parameters correctly without actually doing a transformation? Then we could have a separate test for passing parameters to the XSLTProcessor. It just just seems more in the unit test spirit of "test one thing". --Brent |
