|
From: Craeg S. <cs...@ar...> - 2003-04-08 20:42:17
|
> Did you have any thoughts about my suggestion to move > getXSLParameters() into XSLTMethod? I'd be happy to put together a > patch for that as well. Yes, I think its the right thing to do. There is nothing processor-specific about grabbing the params, so why should the method be in a processor specific class? > > Would you be willing to add a test or two for this > > new behavior to the unit test suite? It should > > OK, I'll take a look at it. Any suggestions for examples to follow? Why don't you take a look at TestXSLTMethod.py, test_07 tests scalar parameters and test_08 tests object parameters. All you need to do is create (at least) two more tests (test_31 and test_32) that are a duplicate of these except that they override the parameters via self.app.REQUEST, and then use self.assertEquals() to ensure they get the properly overridden results. Another good test would be to override the value with the *same* value, to make sure that doesn't somehow mess something up. I think you will be amazed how easy it is to add a test-- ZopeTestCase rocks! BTW, the reason the test methods are numbered that way is so they execute in order. Otherwise I have a hard time matching the results to the test... --Craeg |
