SourceForge has been redesigned. Learn more.
Close

#6 temporary KeepBuffer like behavior for /detach

closed
nobody
None
5
2011-02-15
2008-11-09
No

I'd like to submit a patch which adds a switch to /deatch to temporarely enable a KeepBuffer-like behavior (until the next join). I had to add a ClearBuffer after the buffer playback on /join. Otherwise the buffer wouldn't have been cleared.
If their are any options to enable the same behavior I'd appreciate a hint.

Regards

Discussion

  • Sebastian Ramacher

    File Added: znc-tempkeepbuffer.patch

     
  • Psychon

    Psychon - 2008-12-04

    Hi,

    thanks for another patch, you are becoming a really active contributor. :)
    I haven't replied to this before because I only now noticed this. sf.net doesnt like me, I guess.

    I think I like this idea, but we have a release scheduled and this patch will have to wait until after. Sorry.

    Some more technical comments:
    FFS, use tabs instead of spaces for indent! And try to reduce the number of trailing spaces. Git warns me on both of this, but still I think it's not nice. Oh and your forgot to change the output of '/msg *znc help'.

    I fixed this myself and will also fix some other minor style things in a git branch for this. I will ask the others wether this patch should go in.

    Now the bad thing:
    I haven't tested myself, but the unconditional CChan::ClearBuffer() in CChan::JoinUser() should break KeepBuffer.
    Also, I'm pretty sure your change to CChan::KeepBuffer() breaks both webadmin display and config writing.

    I will look into these issues when/if it is decided that the feature is a good idea (which I think).

    The git branch can be found here:
    http://git.znc.in/?p=psychon/znc.git;a=shortlog;h=refs/heads/znc.net-tempkeepbuffer
    (it will go away after the patch is merged to the main repo)

    psychon

     
  • Sebastian Ramacher

    > FFS, use tabs instead of spaces for indent! And try to reduce the number
    > of trailing spaces. Git warns me on both of this, but still I think it's
    > not nice. Oh and your forgot to change the output of '/msg *znc help'.

    I'll keep that in mind.

    > I haven't tested myself, but the unconditional CChan::ClearBuffer() in
    > CChan::JoinUser() should break KeepBuffer.

    It breaks KeepBuffer. But I didn't understand the features of KeepBuffer good enough at the time I wrote the patch. I'm currently working on a new one. I'll hope to have it ready at the end of next week.

     
  • Psychon

    Psychon - 2011-02-15
    • status: open --> closed
     
  • Psychon

    Psychon - 2011-02-15

    Sorry, doesn't look like this patch will end up in znc.

     

Log in to post a comment.