#4 new admin module

closed-fixed
Psychon
None
5
2009-02-16
2008-01-27
No

I updated and rewrote some parts of the admin module from the crox branch (available at http://svn.kuja.in/viewvc.cgi/znc/branches/crox/modules/admin.cpp?revision=1042&view=markup\) so it meets my demands.

It includes complete help output and it should be easy to extend it with additional commands. I'd be glad to see it in an upcoming release.

Discussion

  • Sebastian Ramacher

    new admin module

     
  • Nobody/Anonymous

    Logged In: NO

    Hi,

    how about this:
    #define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))

    I think this is easier to understand.

    Why do you have a try {} catch () blog in OnModCommand? Why is there some code for handling awaysuffix, which was replaced by the awaynick module some time ago?

    Besides that: Looks nice, I'll tell crox to take a look at it.

    That code makes me think about having some general code in CModule for handling those commands...

     
  • Sebastian Ramacher

    Logged In: YES
    user_id=831733
    Originator: YES

    Hi,

    > how about this:
    > #define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
    >
    > I think this is easier to understand.

    I'm using the template here because of http://lists.boost.org/Archives/boost/2006/06/106775.php.

    > Why do you have a try {} catch () blog in OnModCommand?

    I have to admit that it didn't lock at any of znc's core code. So I don't know how exceptions are handled and if any exceptions are thrown by any of the functions I call within the admin module. If it's not necessary I'll remove it.

    > Why is there some code for handling awaysuffix, which was replaced by the awaynick module some time ago?

    I've just added that because I had to change the awaysuffix of another user. If that's possible with the awaynick module I'll remove it.

    Regards,
    Sebastian

     
  • Psychon

    Psychon - 2009-02-16

    Added to znc in r1379.
    This didn't go into -extra, because quite a lot of people seem to want this.

     
  • Psychon

    Psychon - 2009-02-16
    • assigned_to: nobody --> psychon
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks