#13 enhanced route_reply, switch for playbuffer on clientconnect

closed
nobody
None
5
2010-02-25
2010-01-10
Loriaki
No

* enhanced the module route_repley to route list output from MODE calls (i.e.: MODE #channel b)
* added config(user) to switch on/off sendBuffer on Client connect.

Discussion

  • Loriaki

    Loriaki - 2010-01-10

    sugested changes

     
  • Psychon

    Psychon - 2010-01-10

    Hi, thanks for the patch.

    I think it would really be easier to split this up into two patches which can then be handled seperately.
    Also, I wondered if the SendBuffer stuff couldn't be better done as a simple module. As long as it's loaded, it stops all buffer playback. To avoid the buffer still being cleared, one could temporarily enable KeepBuffer. (See OnChanBuffer*() module calls).

    For that route_replies patch: What a mess... :(

    Wouldn't it make more sense to use a function pointer like this:
    typedef bool (CRouteRepliesMod::*pRequestCheck)(const CString &);

    That way one could avoid that quite pointless extra function.

    Sorry, I haven't taken a closer look at the route_replies changes for now.

    psychon

     
  • Loriaki

    Loriaki - 2010-02-25

    closed it, since I made a new one.

     
  • Loriaki

    Loriaki - 2010-02-25
    • status: open --> closed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks