Help save net neutrality! Learn more.
Close

#10 #ifndef _MODULES in Modules.cpp

closed-fixed
Psychon
None
5
2009-02-16
2009-02-08
No

The code in Modules.cpp is encapsulated in a huge #ifdef _MODULES ... #endif block. Nevertheless CModules::LoadModule und CModules::UnloadModule contains #ifndef _MODULES directives. The code in this sections won't be used with or with out _MODULES defined. Is that an artifact from earlier versions?

The attached patch removes the code blocks which won't be compiled anyway.

Discussion

  • Psychon

    Psychon - 2009-02-09

    git blame says that the ifdef around all of Modules.cpp was added in r767 by prozac via one of my patches. The ifdef you want to remove was added in r92 by prozac. So yeah, this looks like an artifact. I'll remove this after the release.

    Oh btw:
    You seem to be interested in ZNC and have submitted a couple of patches.
    Any reason you never visit us on IRC? I'm in #znc on EFNet and on FreeNode.
    Oh and if you want to, I can add you to the AUTHORS file. Just give me the entry you'd like.

    psychon

    P.S.: I'll most likely add your admin module to trunk after 0.064.

     
  • Sebastian Ramacher

    > I'll remove this after the release.

    Great.

    > Any reason you never visit us on IRC? I'm in #znc on EFNet and on
    > FreeNode.

    Already joined.

    > Oh and if you want to, I can add you to the AUTHORS file. Just give me the
    > entry you'd like.

    Sebastian Ramacher <sebastinas@users.sourceforge.net>

    > P.S.: I'll most likely add your admin module to trunk after 0.064.

    That's great news.

     
  • Psychon

    Psychon - 2009-02-16
    • assigned_to: nobody --> psychon
    • status: open --> closed-fixed
     
  • Psychon

    Psychon - 2009-02-16

    Fixed in r1381

     

Log in to post a comment.