#76 MOTD/WebAdmin - no special character allowed?

closed-fixed
nobody
None
5
2010-01-18
2010-01-16
Un1matr1x
No

Hi,

if I enter a MOTD in the WebAdmin f.e.: "neues schöneres Webinterface auf http://domain.tld:1234/" and pres SaveSettings it's changed to: "neues schöneres Webinterface auf http://domain.tld:1234/"

On IRC it's displayed right. - It's no real big Deal - bug if you have to much free time and don't know what you might also fix *gg*

Best Regards
Un1

Discussion

  • Psychon

    Psychon - 2010-01-16

    IRC doesn't really handle charsets at all, so it just works accidentally there.

    For webadmin:
    I think we should switch everything to use UTF-8 here, that might already resolve this issue just by itself. Alternatively there is accept-encoding for <form>.

    Someone else wants to look more closely at this? :/

    A quick googling found this:
    http://intertwingly.net/blog/2004/04/15/Character-Encoding-and-HTML-Forms

     
  • flakes

    flakes - 2010-01-17

    Suggested patch: http://sprunge.us/UbgP?diff

    (Yes, this XML escaping assumes that <?xml encoding="UTF-8"?> e.g. is present in the document, but we have content-type:text/html;charset=utf-8 which does the trick for HTML.)

     
  • flakes

    flakes - 2010-01-18

    Committed revision 1716 with a "fix" ... not always perfect, but perfect if your client sends UTF-8 and/or you use webadmin or an UTF-8 enabled shell to change around stuff.

    http://znc.svn.sourceforge.net/viewvc/znc?view=rev&revision=1716

     
  • flakes

    flakes - 2010-01-18
    • status: open --> closed-fixed
     

Log in to post a comment.