#40 353 (NAMES responce) is lost when not in channel

closed-fixed
Psychon
None
5
2008-03-22
2008-03-16
Anonymous
No

Numeric 353 is lost if the user is not in the channel when it is received, this is noticeable if /names is used while not in the channel. It should show users that are not invisible, but none are ever displayed. (or all users in the channel to ircops under some ircds, often prefixed by a character such as = if they otherwise would not be shown)

I've looked in the source code, and confirmed that these are dropped on lines 332-333 of IRCSock.cpp (as of revision 976).

----
Xaquseg - IRCHighWay, server co-admin of avalon.*

Discussion

  • Nobody/Anonymous

    Logged In: NO

    This one should fix it by forwarding those messages to the user.

    --- IRCSock.cpp.orig 2008-03-18 17:12:46.000000000 +0100
    +++ IRCSock.cpp 2008-03-18 17:26:46.000000000 +0100
    @@ -329,8 +329,10 @@ void CIRCSock::ReadLine(const CString& s
    sRest.Trim();
    // Todo: allow for non @+= server msgs
    CChan* pChan = m_pUser->FindChan(sRest.Token(1));
    - if (!pChan) // Todo: should this still be forwarded to clients?
    + if (!pChan) {
    + m_pUser->PutUser(sLine);
    return;
    + }

    CString sNicks = sRest.Token(2, true);
    if (sNicks.Left(1) == ":") {

     
  • Psychon

    Psychon - 2008-03-22
    • assigned_to: nobody --> psychon
    • status: open --> closed-fixed
     
  • Psychon

    Psychon - 2008-03-22

    Logged In: YES
    user_id=1654410
    Originator: NO

    Thanks for reporting (and thanks for the patch in the comment, but I kind of didn't notice it).

    Fixed in rev 990.

    psychon

     

Log in to post a comment.