Re: [ZMapServer-Developers] Patches for WMSAdapter

[Sean G. <sgi...@fr...>]

On Mar 11, 2004, at 7:34 AM, Titus v.d. Malsburg wrote:

>
> I have now a few addtitions to WMSAdapter.py, WMSClient.py, 
> wmsCapabilities.zpt and wmsMetaData.zpt
>
>   * a refresh button for the "wms capabillities" tab
>     (get new capabillities from the WMS server)
>   * an slightly improved capabillities parser
>     (arbitraryly deep nested layers)
>   * getFeatureInfo Support
>   * wmsMetaData.zpt shows protocol version
>
> I now want to know how to contribute these changes.  Sean, in one of 
> your last mails you asked me if I have a sourceforge accoutn.  I don't 
> have one and I don't really know how this sourceforge stuff works.  
> Would I commit my changes directly into the main CVS-tree?  Somehow I 
> would prefer if you would look over my changes before cecking it in.  
> Maybe you don't like some of the things I do.  Therefore I propose to 
> send you either one patch containing everything the simply the 
> affected files.
>
> Some things remain unsolved:
>
>   * getFeatureInfo:  Mapserver returns error-messages as
>     png files (not in the specified format)
>
> As reponse format for getFeatureInfo requests Mapserver supports three 
> formats: text/html, text/plain and GML.  There are now two problems:
>
>   * If I send a getFeatureInfo request for a layer containing
>     pixel-data, Mapserver returns a error message that is
>     obviously wrong.  It tells that the QUERY_LAYERS parameter
>     was not supplied (which is not true in my case)
>
>   * the errormessage is a png-file with the message drawn on
>     it (not GML or whatever I specified).
>
> It is left to the user of WMSAdapter to detect this and do something 
> appropriate.
>
> Another nice thing (besides the solutions for these problems) would be 
> the validation of the capabillities before the actual parsing.
>
> Sorry, this is little bit much at once.
>
>   Titus
>

Hi Titus,

Send me personally the files and I will be happy to try them out and 
add the
changes to WMSAdapter.  Thanks for the contribution!

cheers,
Sean

--
Sean Gillies
sgillies at frii dot com
http://users.frii.com/sgillies