#276 Remove unnecessary null pointer checks

[Markus Elfring]

Extra null pointer checks are not needed in functions like the following.

• buffer_plot
• testUtilCmpPngs

[Git Lost]

Well I think this comes down to a style preference, mine being to check for NULL before calling free(), to make the logic explicit.

[Markus Elfring]

I would prefer to get rid of another bit of redundant source code.

[Git Lost]

Yes I can see that point of view. If you wish to do a Merge Request I'll merge it, thanks.

[Markus Elfring]

💭 I am curious if another software developer (besides me) can get into the mood to apply a corresponding update suggestion which could be generated by the software “Coccinelle” (also with the help of a variant from the following script).

@Remove_unnecessary_pointer_checks@
expression x;
@@
-if (\(x != 0 \| x != NULL\))
    free(x);

[Git Lost]

That would be useful, yes. Will try it myself at some stage, and although this particular change isn't high on my to-do list, there may be others that are more so!