#189 Aztec GS1 mode generates incorrect barcode

[Milton Neal]

Hi all
Was working with the Aztec code and discovered it doesn't generate a correct symbol in GS1 mode.
Example below ....
Data:
[01]03453120000011[17]120508[10]ABCD1234[410]9501101020917
The barcode generated produces: (see image)
01034531200000111712050810ABCD1234\000/7397 77 70 37,
The result is the same when using Barcode Studio 2.7
Worked through the code but with specs I can't determine what is causing the problem.
Any ideas.. Thanks Milton

[Milton Neal]

Think I found the cause of the problem
if ((reduced_encode_mode[i] == 'P') || (reduced_encode_mode[i] == 'p')) {
if (gs1 && (reduced_source[i] == '[')) {
if (!az_bin_append(0, 5, binary_string)) return ZINT_ERROR_TOO_LONG; // FLG(n)
if (!az_bin_append(0, 3, binary_string)) return ZINT_ERROR_TOO_LONG; // FLG(0) = FNC1
} else if.........
following line 780 add the above line.
This seems to work now. Can you check if this is correct.
Thanks Milton

[Git Lost]

That looks spot on Milton. I made that change and verified it with tec-it.com and got the same result. Will commit the change with tests this evening. What did you use to decode the faulty version do you mind me asking? Martin

[Milton Neal]

Hi Martin
I'm using a Symbol Technologies (Zebra)DS9208 scanner, I picked up on Ebay to replace my old scanner that died. I picked this unit mainly because it supported Han Xin code. I also use a couple of phone apps one ZXing and the other by Cognex but they don't seem to support Aztec GS1.
Cheers Milton

[Git Lost]

I see, thanks for the info. Yeah ZXing has limited GS1 support, for QR and CODE128 only I think.

If you could confirm that the change as committed works for you, please let us know.

Really appreciate the reports - keep em coming! Cheers Martin

[Milton Neal]

Hi Martin
I tested your commit with the following data and they decoded correctly with my scanner.

[01]95012345678903[3103]000123
[01]03453120000011[17]120508[10]ABCD1234[410]9501101020917
[01]04610044273252[21]LRFX)k<C7ApWJ[91]003A[92]K8rNAqdvjmdxsmCVuj3FhaoNzQuq7Uff0sHXfz1TT/doiMaGQqNF+VPwMvwVbm1fxjzuDt6jxLCcc8o/tqbEDA==

[Git Lost]

Thanks very much Milton, will add the extra 2 examples to the tests.

[Milton Neal]

I think we can call this issue sorted and close this ticket. Thanks all, Milton

[Robin Stuart]

Thank you for the feedback. Closing.