Menu

#109 QR code populate_grid parameter naming issue (minor)

1.0
closed
None
2018-11-02
2018-06-22
No

The QR Code source code contains two data stream variables: datastream and fullstream. One contains ECC data, the other does not. The call to the populate_grid function passes fullstream as the 3rd parameter, but the parameter name inside the method is datastream, giving a false impression of the variable that is being used and the data which it represents. I think this third parameter in the populate_grid function should be renamed to fullstream to accurately reflect its meaning and to be consistent with the rest of the QR Code source code conventions.

Discussion

  • Daniel Gredler

    Daniel Gredler - 2018-06-22

    By extension, the same should probably happen in the cwbit function (for the name of the first parameter).

     
  • Harald Oehlmann

    Harald Oehlmann - 2018-11-02
    • status: open --> closed
    • assigned_to: Harald Oehlmann
     
  • Harald Oehlmann

    Harald Oehlmann - 2018-11-02

    Thank you. Both committed by [7141e2]

     

Log in to post a comment.

MongoDB Logo MongoDB