#106 QR code mode optimization possible bug

[Daniel Gredler]

I'm not sure if this is a bug or not, but the the block of code in define_mode which checks for alphanumeric characters says in the comment that it checks for sequences of less than 4 characters, but the logic appears to be checking for sequences of less than 6 characters (just like the numeric checking block immediately above). I guess either the comment is wrong, or the code is wrong?

https://sourceforge.net/p/zint/code/ci/master/tree/backend/qr.c#l114

[Robin Stuart]

Thanks, Daniel,

That is a mistake, it should be 4. I have changed line 122 to read

if (mlen < 4) {

Robin.

[Robin Stuart]

Thanks, Daniel,

That is a mistake, it should be 4. I have changed line 122 to read

if (mlen < 4) {

Robin.