|
From: Robin S. <rst...@gm...> - 2018-01-29 19:09:48
|
Hi Sebastian, Yes, I have had a response from the glabels team and their requirements seem to be compatible with the code patch in my previous email, so I will add this to the repository and make it "official". Hope this helps, Robin. On 26 January 2018 at 16:34, Sebastien Marie <se...@on...> wrote: > On Tue, Jan 23, 2018 at 08:54:07PM +0000, Robin Stuart wrote: > > Hi Sebastian, > > > > Okay, the problem isn't with symbol->rows after all. From what I can > gather > > a EAN symbol has a limited number of "valid" sizes from 80% to 200%. The > > code at the moment enforces 100% scale (with an x-dimension of 0.33mm). I > > have made some changes (below) which should make the symbol size more > > flexible but which still enforces the correct aspect ratio. If you want > to > > get rid of the problem altogether you can just delete this whole chunk of > > code. > > I would prefer to avoid diverging too much from upstream (you). With your > patch, glabels is usable enought for my users for now. > > But the specification you mentioned stands that 75% would be allowable too > (x-dimension 0.25mm) if bar height is kept to 18.28mm (80 %). > > > Since this section of code is specifically intended for interfacing with > > glabels I think this needs to be checked with the glabels team to find > out > > how it is expected to work before committing any changes to the > repository. > > Did you already contact them ? or should I open an bug report to them ? > > Thanks. > -- > Sebastien Marie > |