Thread: [zd1211-devs] HEADSUP: CVS style cleanup
Status: Beta
Brought to you by:
mayne
From: Roman K <rom...@ma...> - 2005-03-24 16:08:21
|
Hi, I am going to fix style for all src. So that we wouldn't get to diff problems in a future. As I noted, some of developers use double space alignment. Please tune your favorite editors to display tabs as 2 spaces and use tabs instead of spaces. This allows for everyone to tune its own favorite align style. I plan to start and complite this dirty work this weekend. Styling would be done according CodingStyle of Linux. rik |
From: Mike P. <mp...@re...> - 2005-03-24 17:03:32
|
On Thu, Mar 24, 2005 at 07:07:24PM +0300, Roman K wrote: > I am going to fix style for all src. So that we wouldn't get to diff > problems in a future. I think that would be a sensible way of handling this problem - so we only have to go through the pain of reading through diffs containing formatting changes once. And then get to have things nicely formatted for ever more :). > I plan to start and complite this dirty work this weekend. > Styling would be done according CodingStyle of Linux. Good idea. In particular it will make me happy if you apply the rules in that document wrt lines of code like: if (condition) do_this; ie that there should always be a newline between the condition and do_this. I've noticed a lot of changes in CVS that make code look like the above example and personally I find it ugly and unreadable. Mike |
From: Arno W. <ak...@th...> - 2005-03-24 17:21:49
|
Hey, I agree with Mike about adding some newlines, but not to many! I'd like something like this: void test(int foo) { int bar; if (foo==bar) { do_this(); } else { do_that(); } } I really dislike to many newlines like this: void test(int foo) { int bar; if (foo==bar) { do_this(); } else { do_that(); } } Ciao, Arno -- Arno Willig <ak...@th...> |
From: Roman K <rom...@ma...> - 2005-03-24 17:35:21
|
Hi, > Hey, > > I agree with Mike about adding some newlines, but > not to many! > > I'd like something like this: > > void test(int foo) { > int bar; > > if (foo==bar) { > do_this(); > } else { > do_that(); > } > } http://users.inse.ru/~rik/zd1211/CodingStyle.txt Chapter 3 :-), also K&R > I really dislike to many newlines like this: > > void test(int foo) > { > int bar; > > if (foo==bar) > { > do_this(); > } > else > { > do_that(); > } > } > > Ciao, Arno > > -- > Arno Willig <ak...@th...> > > |