[zd1211-devs] [PATCH REWRITE] zd_mac_clear locking
Status: Beta
Brought to you by:
mayne
From: Bryan R. <br...@br...> - 2006-06-03 05:41:57
|
Hello again. I've been reviewing the zd1211rw code with the thought of working on ad-hoc mode. While reading I found the amusing locking in zd_mac_clear(). Daniel, Ulrich, what are your thoughts on: --- zd1211_2006-06-01/zd_mac.c.orig 2006-06-01 03:09:28.000000000 -0700 +++ zd1211_2006-06-01/zd_mac.c 2006-06-02 22:14:25.000000000 -0700 @@ -125,9 +125,6 @@ void zd_mac_clear(struct zd_mac *mac) { - /* Aquire the lock. */ - spin_lock(&mac->lock); - spin_unlock(&mac->lock); zd_chip_clear(&mac->chip); memset(mac, 0, sizeof(*mac)); } (zd_chip_clear() does not seem to require mac->lock) Thanks, Bryan |