[Zabbix-developers] zabbix_agentd not setting SOCK_CLOEXEC on fds created by accept

[edward y. <edw...@gm...>]

Hi:

zabbix_agentd does not set SOCK_CLOEXEC on fds created by `accept` call,
which lead to fd leaking to children processes created by zabbix_agentd.

In function zbx_tcp_accept:

https://github.com/zabbix/zabbix/blob/trunk/src/libs/zbxcomms/comms.c#L1204

fd `accepted_socket` is created but not set SOCK_CLOEXEC.

Is it by design, or it's OK to fix by added fcntl SOCK_CLOEXEC?

Thanks!