#32 Test cases are not passing in current version (1.11.223)

[Anonymous]

tin@wazowski:~/Yapsy-1.11.223$ python runtests.py
..................................................................F...........................
======================================================================
FAIL: test_default_plugins_place_is_parent_dir (test.test_PluginFileLocator.PluginFileLocatorTest)
Test a non-trivial default behaviour introduced some time ago :S

---

Traceback (most recent call last):
File "/home/tin/Yapsy-1.11.223/test/test_PluginFileLocator.py", line 195, in test_default_plugins_place_is_parent_dir
self.assertTrue("package/yapsy" in pl.plugins_places[0])
AssertionError: False is not true

---

Ran 94 tests in 0.109s

FAILED (failures=1)

[Thibauld Nion]

The tests are passing quite well on automatic testing: https://travis-ci.org/tibonihoo/yapsy

Here it's failing because you move the sources and tests outside the package folder.

I don't mean it's your fault, just that the "external" settings have changed and there is no real bug in yapsy related to that.

The best I can do is to see how to make this test more flexible, but this is low priority.

[Igor Gnatenko]

Actually I just run python3 setup.py test which is proper way I think.

[Thibauld Nion]

Sure, the test is just too strict for the way you unpacked yapsy: it expects the "yapsy" folder to be in the "package" folder, but in your case it's directly below the Yapsy-1.11.123.

[Thibauld Nion]

Here is the fix (which I hope, is cross-platform enough, we'll see with the CI):
https://sourceforge.net/p/yapsy/code/ci/0f24c72014ebc79beb812fbaefc15e4edd3f50d4/

[Thibauld Nion]

I haven't heard of the pb coming back since the fix mentionned above, so closing this ticket.