[Yap-users] yap-6.2.2 fails to build with gcc-5.0

[Petr P. <pp...@re...>]

Hello,

Fedora Linux distribution updated GCC compiler to version 5.0 and
unfortunatelly, latest stable yap 6.2.2 fails to build now:

make[1]: Entering directory '/home/test/fedora/yap/yap-6.2.2/packages/swi-minisat2/C'
g++ -c -shared -fPIC -O3 -fomit-frame-pointer -Wall -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic  -DHAVE_CONFIG_H -D_YAP_NOT_INSTALLED_=1 -I. -I../../.. -I./../../../include   ./Solver.C -o Solver.o
g++ -c -shared -fPIC -O3 -fomit-frame-pointer -Wall -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic  -DHAVE_CONFIG_H -D_YAP_NOT_INSTALLED_=1 -I. -I../../.. -I./../../../include   ./pl-minisat.C -o pl-minisat.o
./Solver.C: In member function 'bool Solver::addClause(vec<Lit>&)':
./Solver.C:123:41: error: 'Clause_new' was not declared in this scope
         Clause* c = Clause_new(ps, false);
                                         ^
./Solver.C:123:41: note: suggested alternative:
In file included from ./Solver.h:29:0,
                 from ./Solver.C:20:
./SolverTypes.h:122:20: note:   'Clause_new'
     friend Clause* Clause_new(const V& ps, bool learnt = false) {
                    ^
./Solver.C: In member function 'lbool Solver::search(int, int)':
./Solver.C:602:59: error: 'Clause_new' was not declared in this scope
                 Clause* c = Clause_new(learnt_clause, true);
                                                           ^
./Solver.C:602:59: note: suggested alternative:
In file included from ./Solver.h:29:0,
                 from ./Solver.C:20:
./SolverTypes.h:122:20: note:   'Clause_new'
     friend Clause* Clause_new(const V& ps, bool learnt = false) {
                    ^
Makefile:68: recipe for target 'Solver.o' failed
make[1]: *** [Solver.o] Error 1

This is caused by a this GCC change
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59366> comment by GCC developers
as "a friend function template defined in a class was found without ADL".

After reading yap development tree, I can say it's also affected.

-- Petr