From: Randy W. S. <RandyS@ThePierianSpring.org> - 2003-12-12 01:20:22
|
I scanned CPAN looking at the contents of META.yml files. Out of 6296 files scanned I only encountered one error which you can find at <http://search.cpan.org/dist/Test-Deep/META.yml>. The error was for the value in the 'version_from' field. Error in file 'Test-Deep-0.082/META.yml': --- !perl/YAML::Error code: YAML_PARSE_ERR_BAD_IMPLICIT msg: Unrecognized implicit value './lib/Test/Deep.pm' line: 5 document: 1 ... What is wrong with this value? Randy. PS: Fergal, Do you know where this field originated? It is not part of the current spec <http://module-build.sourceforge.net/META-spec.html> nor is it part of the proposed 1.1 spec <http://nntp.x.perl.org/group/perl.perl5.porters/86144>. Thanks. META.yml fields in use abstract 38 author 47 build_requires 220 conflicts 204 date 11 distribution 1 distribution_type 744 dynamic_config 28 generated_by 740 installdirs 497 license 248 module_name 9 name 745 no_index 17 private 48 provides 188 recommends 212 requires 723 version 745 version_from 496 748 'META.yml' files found while searching in 6296 distributions. |
From: Michael G S. <sc...@po...> - 2003-12-12 01:51:36
|
On Thu, Dec 11, 2003 at 08:19:58PM -0500, Randy W. Sims wrote: > I scanned CPAN looking at the contents of META.yml files. Out of 6296 > files scanned I only encountered one error which you can find at > <http://search.cpan.org/dist/Test-Deep/META.yml>. The error was for the > value in the 'version_from' field. > > Error in file 'Test-Deep-0.082/META.yml': > --- !perl/YAML::Error > code: YAML_PARSE_ERR_BAD_IMPLICIT > msg: Unrecognized implicit value './lib/Test/Deep.pm' > line: 5 > document: 1 > ... > > What is wrong with this value? I think its confused by the leading '.'. I believe there's a YAML.pm bug where it doesn't like having non-alphanumeric characters in an implicit value (but its perfectly valid YAML). So this would be ok: version_from: lib/Test/Deep.pm but this will confuse YAML.pm version_from: ./lib/Test/Deep.pm and would have to be quoted: version_from: './lib/Test/Deep.pm' A work around is to remove the './' from Test::Deep's VERSION_FROM. > PS: Fergal, Do you know where this field originated? It is not part of > the current spec <http://module-build.sourceforge.net/META-spec.html> > nor is it part of the proposed 1.1 spec > <http://nntp.x.perl.org/group/perl.perl5.porters/86144>. Thanks. Its generated by MakeMaker. I threw it in since its a useful bit of static data that maybe someone might want. Might be worth considering adding to the spec, but not at all critical. -- Michael G Schwern sc...@po... http://www.pobox.com/~schwern/ Do you actually think about what you are saying or is it an improvisational game of Mad Libs that you play in your head? |
From: Randy W. S. <RandyS@ThePierianSpring.org> - 2003-12-12 05:21:13
|
On 12/11/2003 8:51 PM, Michael G Schwern wrote: > On Thu, Dec 11, 2003 at 08:19:58PM -0500, Randy W. Sims wrote: > >>I scanned CPAN looking at the contents of META.yml files. Out of 6296 >>files scanned I only encountered one error which you can find at >><http://search.cpan.org/dist/Test-Deep/META.yml>. The error was for the >>value in the 'version_from' field. >> >>Error in file 'Test-Deep-0.082/META.yml': >>--- !perl/YAML::Error >>code: YAML_PARSE_ERR_BAD_IMPLICIT >>msg: Unrecognized implicit value './lib/Test/Deep.pm' >>line: 5 >>document: 1 >>... >> >>What is wrong with this value? > > > I think its confused by the leading '.'. I believe there's a YAML.pm > bug where it doesn't like having non-alphanumeric characters in an implicit > value (but its perfectly valid YAML). [...] Ok, thanks. >>PS: Fergal, Do you know where this field originated? It is not part of >>the current spec <http://module-build.sourceforge.net/META-spec.html> >>nor is it part of the proposed 1.1 spec >><http://nntp.x.perl.org/group/perl.perl5.porters/86144>. Thanks. > > > Its generated by MakeMaker. I threw it in since its a useful bit of > static data that maybe someone might want. Might be worth considering > adding to the spec, but not at all critical. > Doh, I guess I should have looked at the generated_by field. It did give me the idea for more meta statistics though <http://www.thepierianspring.org/meta.stats> hmm, I wonder why HMX is overriding MakeMaker to do what MakeMaker already does? (in Convert::Binary::C and Tie::Hash::Indexed) <http://search.cpan.org/dist/Tie-Hash-Indexed/Makefile.PL> <http://search.cpan.org/dist/Tie-Hash-Indexed/META.yml> Regards, Randy. |
From: Michael G S. <sc...@po...> - 2003-12-12 05:35:42
|
On Fri, Dec 12, 2003 at 12:21:02AM -0500, Randy W. Sims wrote: > Doh, I guess I should have looked at the generated_by field. It did give > me the idea for more meta statistics though > <http://www.thepierianspring.org/meta.stats> I would be nice to know how many people have NO_META set in their Makefile.PL if you're feeling ambicious. > hmm, I wonder why HMX is overriding MakeMaker to do what MakeMaker MHX? > already does? (in Convert::Binary::C and Tie::Hash::Indexed) > > <http://search.cpan.org/dist/Tie-Hash-Indexed/Makefile.PL> > <http://search.cpan.org/dist/Tie-Hash-Indexed/META.yml> MakeMaker has no way to set a license or distribution_type. There's no reason these couldn't be added as WriteMakefile arguments. Patches welcome. -- Michael G Schwern sc...@po... http://www.pobox.com/~schwern/ You can't control the universe with a jar of red pepper. http://www.goats.com/archive/981004.html |
From: Marcus Holland-M. <mhx...@gm...> - 2003-12-12 22:11:19
|
> > hmm, I wonder why HMX is overriding MakeMaker to do what MakeMaker > MHX? > > already does? (in Convert::Binary::C and Tie::Hash::Indexed) > > > > <http://search.cpan.org/dist/Tie-Hash-Indexed/Makefile.PL> > > <http://search.cpan.org/dist/Tie-Hash-Indexed/META.yml> > > MakeMaker has no way to set a license or distribution_type. There's > no reason these couldn't be added as WriteMakefile arguments. Patches > welcome. Yes, the license was the main reason. I disliked seeing that "License: Unknown" at search.cpan.org. The small hack worked fine for me. I wanted to throw it out when MakeMaker fully supports META.yml. Maybe I'll get around to providing a patch during the next couple of weeks. -- Marcus |
From: Michael G S. <sc...@po...> - 2003-12-13 00:30:26
|
On Fri, Dec 12, 2003 at 11:11:07PM +0100, Marcus Holland-Moritz wrote: > Yes, the license was the main reason. I disliked seeing that > "License: Unknown" at search.cpan.org. The small hack worked > fine for me. I wanted to throw it out when MakeMaker fully > supports META.yml. Its unlikely that MakeMaker will ever fully support META.yml. Just the most important and/or easiest to implement bits. > Maybe I'll get around to providing a patch during the next > couple of weeks. Thanks. -- Michael G Schwern sc...@po... http://www.pobox.com/~schwern/ It's Flypaper Licking time! |
From: Randy W. S. <RandyS@ThePierianSpring.org> - 2003-12-13 04:21:39
|
On 12/12/2003 6:09 PM, Michael G Schwern wrote: > On Fri, Dec 12, 2003 at 11:11:07PM +0100, Marcus Holland-Moritz wrote: > >>Yes, the license was the main reason. I disliked seeing that >>"License: Unknown" at search.cpan.org. The small hack worked >>fine for me. I wanted to throw it out when MakeMaker fully >>supports META.yml. > > > Its unlikely that MakeMaker will ever fully support META.yml. Just the most > important and/or easiest to implement bits. > > > >>Maybe I'll get around to providing a patch during the next >>couple of weeks. > > > Thanks. > > Haven't really had a chance to look, but what will older MakeMakers do when they see unknown arguments passed in? I think it generates a warning and ignores it. If that's the case, the only work-around I can think of off-hand is to define an package variable in main to define a META structure that MakeMaker can look for, but that's a bit ugly. BTW, I like the idea of checking for NO_META. Unfortunately, I'm on my laptop till Tuesday and don't have access to a minicpan mirror nor the connection speed to make one. I'll add it next week; it should be trivial, but if someone wants to take a crack at it before then, it can be found at <http://www.thepierianspring.org/meta_stats.pl>. Regards, Randy. |
From: Randy W. S. <RandyS@ThePierianSpring.org> - 2003-12-13 05:34:28
|
On 12/12/2003 11:21 PM, Randy W. Sims wrote: > On 12/12/2003 6:09 PM, Michael G Schwern wrote: > >> On Fri, Dec 12, 2003 at 11:11:07PM +0100, Marcus Holland-Moritz wrote: >> >>> Yes, the license was the main reason. I disliked seeing that >>> "License: Unknown" at search.cpan.org. The small hack worked >>> fine for me. I wanted to throw it out when MakeMaker fully >>> supports META.yml. >> >> >> >> Its unlikely that MakeMaker will ever fully support META.yml. Just >> the most >> important and/or easiest to implement bits. >> >> >> >>> Maybe I'll get around to providing a patch during the next >>> couple of weeks. >> >> >> >> Thanks. >> >> > > Haven't really had a chance to look, but what will older MakeMakers do > when they see unknown arguments passed in? I think it generates a > warning and ignores it. If that's the case, the only work-around I can > think of off-hand is to define an package variable in main to define a > META structure that MakeMaker can look for, but that's a bit ugly. > Ignore me; it's late. Actually, we can use the same technique we use now: check MakeMaker's VERSION before passing the arguments. |
From: Marcus Holland-M. <mhx...@gm...> - 2003-12-14 00:18:01
Attachments:
mm_meta_license.diff
|
> On Fri, Dec 12, 2003 at 11:11:07PM +0100, Marcus Holland-Moritz wrote: > > Yes, the license was the main reason. I disliked seeing that > > "License: Unknown" at search.cpan.org. The small hack worked > > fine for me. I wanted to throw it out when MakeMaker fully > > supports META.yml. > > Its unlikely that MakeMaker will ever fully support META.yml. Just the most > important and/or easiest to implement bits. > > > > Maybe I'll get around to providing a patch during the next > > couple of weeks. > > Thanks. Here's a first shot. The attached patch (against the latest repository snapshot) adds a 'LICENSE' parameter to MakeMaker. It also tries to make the metafile output a little more Module::Build-ish. I didn't add a parameter for 'DISTRIBUTION_TYPE', since this is currently hardcoded also in M::B. As this is my first patch to MM, please let me know if I missed anything. -- Marcus |