#201 wrapper.on_exit SHUTDOWN doesn't work

[teapot418]

Hello,

I used the configuration rules with these values:
wrapper.on_exit.2=SHUTDOWN
wrapper.on_exit.default=RESTART
wrapper.on_signal.default=RESTART

My application exited with exit code 2
(in wrapper.log : exit code posix process: 512 application(status/signal): 2/-1)
but application was restarted by the wrapper
(in wrapper.log : restart internal RUNNING controller killed restart handler)

I think that the reason of the bug is in WrappedJavaProcess.java, killedRestartHandler and restartHandler
There is this condition:

if ((allowRestart() && exitCodeRestart()
        && !exitCodeShutdown() && !exitCodeStop())
        ||
        (allowRestart() && exitSignalRestart()
                && !exitSignalShutdown() && !exitSignalStop()))
{
    restartInternal("controller killed restart handler");
}

In my case, the first part of the condition is false because of exit code 2
(allowRestart() && exitCodeRestart() && !exitCodeShutdown() && !exitCodeStop())

but the second part of the condition is true because of on_signal default rule
(allowRestart() && exitSignalRestart() && !exitSignalShutdown() && !exitSignalStop())

I think this condition should be like this

(allowRestart() && (exitCodeRestart()|| exitSignalRestart())
        && !exitCodeShutdown() && !exitCodeStop())
        && !exitSignalShutdown() && !exitSignalStop())

Regards
Monika

[rzo]

thanks for pointing this out.
will check this for release 13.11

-- Ron

[teapot418]

hello,
I have tried this in new release 13.11, but nothing changed, problem still continues

Regards
Monika

[rzo]

:((
sorry. i will have to check this.

-- Ron

[rzo]

release 13.12
pls report if this issue is resolved or not.

[teapot418]

yes, Issue is solved, thank you.