#321 g_strsplit: a broken usage

[Dmitry Butskoy]

Since the commit 8bfcaf9, yad behaves incorrectly when a form field name is empty (fe. --field="":RO ). Either crashes at all, or some warnings in stderr looking like some usage of uninitialized data...

The problem is a little misunderstanding of the behavior of the glib-2.0 function g_strsplit(). According to the manual:

As a special case, the result of splitting the empty string "" is an empty vector, not a vector containing a single string.
...
If you do need to represent empty elements, you'll need to check for the empty string before calling g_strsplit().

The patch proposed fixes the issue (at least for my a bit complex case).

Surely it drops changes from some recent commits regarding src/option.c -- 17bd94, 8ba82ec (no comments... :) )

[Victor Ananjevsky]

thanks, applied

[Dmitry Butskoy]

I'm worry about other places where the same issue can happen.

For example, in src/form.c :
set_field_value (i, "");
and then in set_field_value() there are calls to g_strsplit(), fe.:
s = g_strsplit (value, options.common_data.item_separator, -1);

etc. etc. etc.