Menu

#83 Check return codes everywhere

SVN
open
5
2008-01-29
2008-01-27
No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "pthread_mutex_init" like in the function "xvc_appdata_init" and from "strdup" in the function "xvc_captypeoptions_copy"?
http://xvidcap.svn.sourceforge.net/viewvc/xvidcap/trunk/src/app_data.c?revision=292&view=markup

Discussion

  • Karl H. Beckers

    Karl H. Beckers - 2008-01-29

    Logged In: YES
    user_id=782084
    Originator: NO

    Is this a bug? (i. e. actually causing problems)

     
  • Karl H. Beckers

    Karl H. Beckers - 2008-01-29
    • assigned_to: nobody --> charly4711
     
  • Markus Elfring

    Markus Elfring - 2008-01-29

    Logged In: YES
    user_id=572001
    Originator: YES

    I suggest to avoid unchecked function calls.
    Would you like to detect every error situation as early as possible?

     

Log in to post a comment.