#46 typo in configure.ac main.c:543: error: `CAP_AVI' undeclared

closed-fixed
5
2006-09-01
2006-04-04
No

CAP_FFM is defined as CAP_AVI.

But CAP_AVI is not in tcap_formats if no libavcodec or
libavformat found.

On my system, I want to use outside ffmpeg. ffmeg has
been known to have security issues so it makes sense to
not use embedded builtin version so I don't have to
update twice.

(I am a package maintainer and developer for pkgsrc; I
am not a ffmpeg developer.)

My avcodec was not detected, because
: undefined reference to `imb_convert
It is not defined in libavcodec. This is a typo. Here
is a fix:

--- work.reed/xvidcap-1.1.3/configure.ac.orig
2006-04-03 17:57:01.000000000 -0700
+++ work.reed/xvidcap-1.1.3/configure.ac
2006-04-03 17:57:09.000000000 -0700
@@ -244,7 +244,7 @@
static_avcodec=$static_avutil
ac_my_avcodec_libs=""
test x`(uname -s)` = xSunOS &&
ac_my_avcodec_libs="-lnsl -lsocket"
-AC_CHECK_LIB_STATIC(avcodec, img_convert,,[unset
ac_cv_lib_avcodec_img_convert ; static_avcodec=no ;
AC_CHECK_LIB(avcodec,
imb_convert,,,[$ac_my_avcodec_libs])],[$ac_my_avcodec_libs])
+AC_CHECK_LIB_STATIC(avcodec, img_convert,,[unset
ac_cv_lib_avcodec_img_convert ; static_avcodec=no ;
AC_CHECK_LIB(avcodec,
img_convert,,,[$ac_my_avcodec_libs])],[$ac_my_avcodec_libs])
AM_CONDITIONAL(HAVE_LIBAVCODEC, test
x$ac_cv_lib_avcodec_img_convert = xyes)

# if avcodec is linked statically, avformat should, too

Discussion

  • Karl H. Beckers

    Karl H. Beckers - 2006-04-08

    Logged In: YES
    user_id=782084

    (pending user confirmation, FIXED)
    Hi Jeremy, what version are you using?
    this issue has been fixed quite a while ago ... dunno
    remember when, but when I look at CVS in 1.1.3-patches
    branch, there is no occurrence of "imb" in configure.ac.
    Also there is no "imb" in rev. 1.27 which is in 1.1.3p7.

     
  • Karl H. Beckers

    Karl H. Beckers - 2006-04-08
    • labels: --> build system
    • assigned_to: nobody --> charly4711
    • status: open --> pending-fixed
     
  • Jeremy C. Reed

    Jeremy C. Reed - 2006-04-08

    Logged In: YES
    user_id=336943

    I was using the 1.1.3 release. According to the webpages it
    is the official version. I thought I looked in CVS, sorry I
    didn't check later code.

     
  • Jeremy C. Reed

    Jeremy C. Reed - 2006-04-08
    • status: pending-fixed --> open-fixed
     
  • Robert Millan

    Robert Millan - 2006-06-26

    Logged In: YES
    user_id=766996

    Aren't you using HEAD for trunk development? It's pretty
    odd that cvs HEAD is broken because it's not actively used.

     
  • Karl H. Beckers

    Karl H. Beckers - 2006-06-26

    Logged In: YES
    user_id=782084

    Well, it appears I haven't merged the 1.1.3patches branch
    with HEAD for a while.

    Also, I prolly won't because I'm within a few weeks of
    putting up 1.1.4pre3 which has so little in common with
    1.1.3 that I won't do a merge. The new version will go to
    SVN (which nicely saves me the work of reorganizing CVS).

    Since I've been rewriting major parts and working from most
    optional bits absent to present, the new version should be a
    lot better tested with compilations without certain elements
    (like without ffmpeg or liblame) and also sport more
    sensible defaults (like defaults which will produce what 90
    percent of people want).

     
  • Karl H. Beckers

    Karl H. Beckers - 2006-09-01
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.