Menu

#792 osxhelp.c wHelp() leaks buffer.page on early-return (Hg port of git PR #161 fix)

fixed
nobody
None
2026-09-14
2026-09-14
No

app/wlib/gtk3lib/osxhelp.c's wHelp() leaks buffer.page on the "Help Topic too long" early-return path (found during a 2026-09-01 cppcheck-deep preview of widening coverage to app/wlib).

The leak was fixed in git (GTK3V2MAIN) as part of PR #161 (2026-09-02, which widened cppcheck/clang-tidy/suppress-inventory to app/wlib generally) by adding the missing free(buffer.page) on both early-return paths.

That fix has not yet been folded into the Hg GTK3V2MAIN mainline. It was deliberately held back at the time because Martin Fischer was mid-way through his own wlib-cleanup work in this same file/area, and a heads-up was sent to the dev mailing list instead of touching the file directly. As of 2026-09-14, Hg's osxhelp.c on GTK3V2MAIN has had no further commits since Ken Shaffer's 2026-04-10 astyle pass — no sign Martin picked this up or edited the file since — so the git fix can now be ported into Hg directly.

Filing this ticket to give the existing git-only fix a tracked number before porting it to Hg via its own bug branch.

Discussion

Anonymous
Anonymous

Add attachments
Cancel