#2 log entries format(s)
Priority: Low
Impact: Cosmetics
The following log() calls seems to be strange due to
message formmating or parameters passing, ...
FILE:LINE: source code
- missing space between %s and text may caused the
log record hard to read
radiusd.c:847: log(L_ERR, "%saccounting
process died - exit.", me);
radiusd.c:850: log(L_ERR, "%sfailed in
select() - exit.", me);
radiusd.c:853: log(L_INFO, "%sexit.", me);
radiusd.c:856: log(L_ERR, "%sexit on signal
(%d)", me, sig);
- some of formats is missing
auth.c:850: log(L_AUTH,
"Login incorrect: [%s] (%s) "
"(external check failed)",
namepair->strvalue,
auth_name(authreq, 1));
- unification of messages with same cause
There are few groups of messages which has various
message texts (only three examples are given)
1. Out of memory (no memory, Out of memory!,...)
2. Can't fork (Accounting: fork: %s, Fork failed ...)
3. Can't open file (cannot open ..., Couldn't open %s
for ...)
The unified message may contain name of the
subsystem which was affected.
Regards David