[xtensa-cvscommit] linux/arch/xtensa/kernel pci-dma.c,1.2,1.3
Brought to you by:
zankel
|
From: <ma...@us...> - 2003-03-20 20:47:43
|
Update of /cvsroot/xtensa/linux/arch/xtensa/kernel In directory sc8-pr-cvs1:/tmp/cvs-serv2825 Modified Files: pci-dma.c Log Message: Use a safer cache invalidation call (_writeback_inv) for PCI DMA. Using _invalidate can throw away dirty cache data, so much more investigation is needed to guarantee it is safe to use here. Index: pci-dma.c =================================================================== RCS file: /cvsroot/xtensa/linux/arch/xtensa/kernel/pci-dma.c,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -d -r1.2 -r1.3 *** pci-dma.c 17 Jan 2003 00:31:30 -0000 1.2 --- pci-dma.c 20 Mar 2003 20:47:35 -0000 1.3 *************** *** 52,56 **** BUG(); case PCI_DMA_FROMDEVICE: /* invalidate only */ ! xthal_dcache_region_invalidate(vaddr, size); break; case PCI_DMA_TODEVICE: /* writeback only */ --- 52,60 ---- BUG(); case PCI_DMA_FROMDEVICE: /* invalidate only */ ! /* perhaps not 100% safe? -- XTFIXME */ ! /*xthal_dcache_region_invalidate(vaddr, size);*/ ! ! /* this is always safe: */ ! xthal_dcache_region_writeback_inv(vaddr, size); break; case PCI_DMA_TODEVICE: /* writeback only */ |