#1 xsnow fails to build with gcc 10

[Andrea Musuruane]

It seems xsnow cannot be built with gcc 10.

I get the following error:
make[4]: Leaving directory '/builddir/build/BUILD/xsnow-2.0.15/src'
/usr/bin/ld: xsnow-dsimple.o:(.bss+0x0): multiple definition of `screen'; xsnow-main.o:(.bss+0xd8): first defined here
collect2: error: ld returned 1 exit status make[4]: *** [Makefile:657: xsnow] Error 1

Full logs here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=41325525

Can you please check? Thanks!!

[Willem Vermin]

AFAIK, gcc-10 is not released yet, so testing is a bit difficult for me.

Can you try this:

line 87 in dsimple.c:
int screen = 0;
Change this to:
static int screen = 0;
and move the line to the top of the file.

[Andrea Musuruane]

The issue should be "Default to -fno-common":
https://gcc.gnu.org/gcc-10/porting_to.html

I think you can use an older gcc version and compile with -fno-common to get the same behaviour.

[Willem Vermin]

Indeed, adding -fno-common to CFLAGS results in the error reported.
The fix mentioned above fixes it, see trunk/xsnow-devel. I will incorporate this in the next release.

[Andrea Musuruane]

Thanks! I'll rebuild xsnow for Fedora 32 with the proposed fix.

[Willem Vermin]

xsnow-2.0.16 is released. Should compile with gcc10. xsnow now runs in all workspaces.
Very soon 2.0.17 will be released, fixing a bug that manifests itself sometimes when
Santa is ploughing throug fallensnow of a moving window.

[Willem Vermin]

2.0.17 is released.