Thread: [Xsltforms-support] [PATCH] Problem with rev388 on XFNode.readonly manifested at xf:select with xf:
Brought to you by:
alain-couthures
From: Kostis A. <ank...@gm...> - 2010-04-20 13:40:29
|
Hi, The single-line commit on rev388("Missing property causing infinite loop") of defining the XFNode.readonly property on node-initialization broke <xf:select> controls, and their itemsets do not get updated when their underlying nodeset change. I have not cheked whether more problems exist with this modification. Reported against Chrome (assuming it applies to all browsers though) The example-form below demonstrate the problem: http://pastebin.com/BsdsxDhh (copied from an older still-unsolved problem on itemsets, ignore the text descriptions) I cannot explain why this happen, but i found that if on XFNode initialization, the XFNode.readonly property is set to 'undefined' instead of 'false', then the problem dissappears, and the infinite recurssion issue remains fixed. (i performed no other tests The patch below performs the suggested modification: (and fixes tabstops and spaces) Index: src/js/xpathexpr/DOM/XNode.js.xml =================================================================== --- src/js/xpathexpr/DOM/XNode.js.xml (revision 396) +++ src/js/xpathexpr/DOM/XNode.js.xml (working copy) @@ -313,7 +313,7 @@ this.valid = true; this.required = false; this.relevant = true; - this.readonly = false; + this.readonly = undefined; this.type = Schema.getType("xsd_:string"); this.schemaType = false; this.bind = null; Regards, Kostis |
From: Kostis A. <ank...@gm...> - 2010-04-21 10:27:04
|
I apologize, with the sible-line patch i submited, the modification: this.readonly = undefined; causes the infinite-recursion on IE indeed to reappear. I thought that Alain's fix was refering to another infinite-recursion i had posted a week ago, https://sourceforge.net/mailarchive/forum.php?thread_name=4BC...@ag...&forum_name=xsltforms-support So my patch is bad, and the very-annoying problem of <xf:select1> not updating their itemsets after submissions remains to be solved. Regards, Kostis. On Tue, Apr 20, 2010 at 4:33 PM, Kostis Anagnostopoulos <ank...@gm...> wrote: > Hi, > > The single-line commit on rev388("Missing property causing infinite > loop") of defining the XFNode.readonly property on node-initialization > broke <xf:select> controls, and their itemsets do not get updated when > their underlying nodeset change. > I have not cheked whether more problems exist with this modification. > Reported against Chrome (assuming it applies to all browsers though) > > > The example-form below demonstrate the problem: > http://pastebin.com/BsdsxDhh > (copied from an older still-unsolved problem on itemsets, ignore the > text descriptions) > > > > I cannot explain why this happen, but i found that if on XFNode initialization, > the XFNode.readonly property is set to 'undefined' instead of 'false', > then the problem dissappears, and the infinite recurssion issue remains fixed. > (i performed no other tests > > The patch below performs the suggested modification: > (and fixes tabstops and spaces) > > Index: src/js/xpathexpr/DOM/XNode.js.xml > =================================================================== > --- src/js/xpathexpr/DOM/XNode.js.xml (revision 396) > +++ src/js/xpathexpr/DOM/XNode.js.xml (working copy) > @@ -313,7 +313,7 @@ > this.valid = true; > this.required = false; > this.relevant = true; > - this.readonly = false; > + this.readonly = undefined; > this.type = Schema.getType("xsd_:string"); > this.schemaType = false; > this.bind = null; > > > Regards, > Kostis > |
From: Kostis A. <ank...@gm...> - 2010-04-22 18:49:14
|
Hi, ok, i cheked it against rev397 and it is now fixed, pick-lists with <xf:itemsets> get indeed updated from files correctly. Thanks, Kostis On Wed, Apr 21, 2010 at 1:26 PM, Kostis Anagnostopoulos <ank...@gm...> wrote: > I apologize, > with the sible-line patch i submited, the modification: > this.readonly = undefined; > causes the infinite-recursion on IE indeed to reappear. > > I thought that Alain's fix was refering to another infinite-recursion > i had posted a week ago, > https://sourceforge.net/mailarchive/forum.php?thread_name=4BC...@ag...&forum_name=xsltforms-support > > So my patch is bad, > and the very-annoying problem of <xf:select1> not updating their > itemsets after submissions remains to be solved. > > Regards, > Kostis. > > > On Tue, Apr 20, 2010 at 4:33 PM, Kostis Anagnostopoulos > <ank...@gm...> wrote: >> Hi, >> >> The single-line commit on rev388("Missing property causing infinite >> loop") of defining the XFNode.readonly property on node-initialization >> broke <xf:select> controls, and their itemsets do not get updated when >> their underlying nodeset change. >> I have not cheked whether more problems exist with this modification. >> Reported against Chrome (assuming it applies to all browsers though) >> >> >> The example-form below demonstrate the problem: >> http://pastebin.com/BsdsxDhh >> (copied from an older still-unsolved problem on itemsets, ignore the >> text descriptions) >> >> >> >> I cannot explain why this happen, but i found that if on XFNode initialization, >> the XFNode.readonly property is set to 'undefined' instead of 'false', >> then the problem dissappears, and the infinite recurssion issue remains fixed. >> (i performed no other tests >> >> The patch below performs the suggested modification: >> (and fixes tabstops and spaces) >> >> Index: src/js/xpathexpr/DOM/XNode.js.xml >> =================================================================== >> --- src/js/xpathexpr/DOM/XNode.js.xml (revision 396) >> +++ src/js/xpathexpr/DOM/XNode.js.xml (working copy) >> @@ -313,7 +313,7 @@ >> this.valid = true; >> this.required = false; >> this.relevant = true; >> - this.readonly = false; >> + this.readonly = undefined; >> this.type = Schema.getType("xsd_:string"); >> this.schemaType = false; >> this.bind = null; >> >> >> Regards, >> Kostis >> > |