David,
> I ran into some problems with openAction being called without an
> associated closeAction. The attached patch fixes the problems in
> XFSelect.js.xml and utils.js.xml.
In XFSelect.js.xml, the corresponding closeAction() call was effectively
missing but I still don't see the necessity of moving openAction() call
in utils.js.xml and it could induce at least extra refreshes. Do you
have a simple test case about this ?
I have committed this anyway...
> In addition, I rolled multiple
> instances of closeAction in XFSubmission.js.xml into a single call
> at the end of the submit function.
>
This sounds more as a small source size reducing and this could change
global behavior so I prefer not to commit this yet...
Thanks!
-Alain
|