[Xsltforms-support] [PATCH] Problem with rev388 on XFNode.readonly manifested at xf:select with xf:
Brought to you by:
alain-couthures
From: Kostis A. <ank...@gm...> - 2010-04-20 13:40:29
|
Hi, The single-line commit on rev388("Missing property causing infinite loop") of defining the XFNode.readonly property on node-initialization broke <xf:select> controls, and their itemsets do not get updated when their underlying nodeset change. I have not cheked whether more problems exist with this modification. Reported against Chrome (assuming it applies to all browsers though) The example-form below demonstrate the problem: http://pastebin.com/BsdsxDhh (copied from an older still-unsolved problem on itemsets, ignore the text descriptions) I cannot explain why this happen, but i found that if on XFNode initialization, the XFNode.readonly property is set to 'undefined' instead of 'false', then the problem dissappears, and the infinite recurssion issue remains fixed. (i performed no other tests The patch below performs the suggested modification: (and fixes tabstops and spaces) Index: src/js/xpathexpr/DOM/XNode.js.xml =================================================================== --- src/js/xpathexpr/DOM/XNode.js.xml (revision 396) +++ src/js/xpathexpr/DOM/XNode.js.xml (working copy) @@ -313,7 +313,7 @@ this.valid = true; this.required = false; this.relevant = true; - this.readonly = false; + this.readonly = undefined; this.type = Schema.getType("xsd_:string"); this.schemaType = false; this.bind = null; Regards, Kostis |