Re: (xslide) xslide Patch #813124: Add msxsl.exe support in xsl-process.el

[xslide S. <xsl...@me...>]

At 7 Nov 2003 21:39 -0500, Glen Peterson wrote:
 > To: Ville Skytt=E4 (scop) or anyone familiar with xsl-process.el
 >=20
 > Looking in the changelog, it seems that you (Ville) did a bunch of the
 > work on xslide-process.el.  Doug Bloebaum (blabes) submitted a patch t=
o

Ville contributed a patch, which I installed.

 > this file and I am confused about some of the code that he changed.  H=
is
 > patch is at:
 >=20
 > https://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D813124&g=
roup_id=3D22964&atid=3D377145
 >=20
 > He deleted and replaced the following code with something that works o=
n
 > msxml but he *may* have broken some other processors in the process.=20
 > I'm not sure how I would go about regression testing this because I
 > don't know which processors use this code.  Do some of the processors

That is the problem with trying to get xslide to support multiple XSLT
processors.  I usually just install any patches for XSLT processors
that I don't use myself since I have no easy way of testing them.  If
it breaks using xslide with a processor that I do use, then I'll fix
it.

 > that have their own specific code also use this "generic" code?  The
 > section of code I am talking about looks like this (before his patch)
 >=20
 > ;; Generic
 > (".*\\<file:\\(\\(/[A-Za-z]:\\)?[^:]+\\):[ \t]*\\(\\([0-9]+\\):[
 > \t]*\\(\\([0-9]+\\):\\)?\\)?"
 > 1 4 6)
 > (".*\\([^ ]+\\.x[ms]l\\):[ \t]*\\([0-9]+\\):[ \t]*\\(\\([0-9]+\\):\\)?=
"
 > 1 2 4)
 > ("^\\([^:]+\\): \\([0-9]+\\): error:"
 > 1 2)
 >=20
 > Also, I'm unclear about how the user selects which processor they want
 > to use.  Xt comes up by default.  If I want to use java apache xalan,

Hopefully C-h k C-c C-p explains it well enough.

 > what would you expect me to do?  I got it to work, but I'm sure I didn=
't
 > do it the recommended way.  It was really cool that it remembered what=
 I
 > wanted after I got it to work.

Command histories are your friend.

 > Do you have some time to review his patch and/or answer my questions,
 > and/or add comments or patches to the code to answer these questions? =
 I
 > will not merge Doug's patch until I get this figured out.  Anyone else
 > want to shed light on the subject?

I'll look at it.

Regards,


Tony Graham.