Menu

Src (SVN)-old Commit Log


Commit Date  
[r8959] by tswift

Fixed yet another bug in incremental table view maintenance,
though this one was obscure. The function
get_list_of_answers_from_answer_list was core dumping. This
function takes the answer list which was produced by
traverse_variant_trie, and copies their corresponding answers to
a list on the heap, constructing the answers as it goes. The
problem arose in cases where no answers needed to be copied, in
which case uninitialized garbage was returned to find_the
visitors, rather than a pointer to a list. The fix was simple --
properly initialize the variable whose value is returned, and
check the return when the function was called.

I didn't think that such a case could happen, so I looked into
why it did, and it turns out it depended on a feature of XSB's
trie hash nodes. A call to a hash node may have the
corresponding position free or bound. If it is free, then when
the hash_handle code executes, it finds the next value to return
by traversing the hash table. It can be the case where there is
no next value. In certain cases, this leads directly to
list_of_answers_for_answer_list returning no answers and to the
problem we had.

Along the way, I also created a debugging macro,
print_hash_handle that helped me verify why things were
happening.
y

2017-01-07 19:37:54 Tree
[r8958] by dwarren

Fix one place where parameterized module names were not handled correctly.
(And cleanup patch in cp_opt.P to make testing of internal variables more
precise.)

2017-01-07 17:48:03 Tree
[r8957] by dwarren

File had syntax error and wouldn't read correctly. Don't know exactly what was
meant for it to compile (or maybe not?), but tired to do minimal change to
make it syntactially correct.

2017-01-07 16:18:24 Tree
[r8956] by "kifer"

recompiled windows dlls for xsb packages -- to account for the changes that Teri made in cinterf.

2017-01-07 07:09:47 Tree
[r8955] by "kifer"

turns out the linix/mac version of makexsb clean was not removing the .so/dylic/xwam files from config/arch.../lib, which was sometimes leading to false bug reports.

2017-01-06 21:39:14 Tree
[r8954] by dwarren

Minor change to handle unsigned arity more cleanly/simply.

2017-01-04 14:40:51 Tree
[r8953] by "kifer"

uncommented xsb_patch_version in version.sh because otherwise the version string looks ugly (has a trailing dot).
Maybe somebody would want to fix that but until then xsb_patch_version shodn't be empty.
Updates related config files, which are generated by configure.

2017-01-04 09:48:26 Tree
[r8952] by dwarren

Recoded nec_different_xwam_files to be simpler and not use
raw integers where clearer options are available (as Michael suggested.)

2017-01-03 19:47:49 Tree
[r8951] by dwarren

Minor casts or change of decls to eliminate warnings from MSVC.

2017-01-03 19:38:27 Tree
[r8950] by tswift

table_once is now opaque.

2017-01-02 23:11:53 Tree
Older >
MongoDB Logo MongoDB