#8 pingtime_str is 1 char too small

closed-accepted
nobody
None
5
2012-12-26
2012-12-03
No

Hi,
The pingtime_str in src/client/meta.h is 1 char too small to hold the ascii (including terminator) of a PING_UNKNOWN response and
hence you get a 1 char buffer overrun; this probably can't cause a real problem, but the compiler options Ubuntu builds with
kill xpilot, and thus don't allow internet connections.
I've filed this as Ubuntu bug https://bugs.launchpad.net/ubuntu/+source/xpilot-ng/+bug/1033250
and have filed a patch on bzr to fix it; which I include below

Discussion

  • Ben Armstrong

    Ben Armstrong - 2012-12-26

    I have applied the patch. Thanks.

     
  • k. siegmund

    k. siegmund - 2012-12-26

    Thank you for the patch. Ben Armstrong applied it.

     
  • k. siegmund

    k. siegmund - 2012-12-26
    • status: open --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks